openwebnet-android icon indicating copy to clipboard operation
openwebnet-android copied to clipboard

Application crashes when trying to add/change gateway on Android 11+

Open olaquetal opened this issue 3 years ago • 3 comments

Hello, I installed the application on a new phone, samsung A52s with Android12. Several issues noticed :

  • Adding an item light or automation is not possible because there is no default getway
  • Trying to access getway parameter crashes the application, android says it crashed because of a bug
  • The shared profiles from another accound doesn't appear

On another phone, same version of android, I have openwebnet which was the restore of my account form another phone, it works well but acessing the getway parameter also crashes the application. Thanks a lot for help! Antonio

olaquetal avatar Nov 27 '22 13:11 olaquetal

Hi @olaquetal, thanks for reporting this.

About the profiles, I confirm that you can still apply existing profiles also on android 13, but that the sharing is not working at the moment. I can look into it, but I have very limited capacity at the moment. I've created a separate pr for this https://github.com/openwebnet/openwebnet-android/issues/109

I didn't notice it, but you are actually right, I've just tested it on android 11 and 13 and the app is actually closing/crashing when trying to add a gateway. So this is definitely a bug or a regression. Would you be able to debug and try to fix this? I haven't updated the app in a long time and I really don't have time to track this down. If you can look into it and open a pr, I'd be more than happy to test it and release a new version. Ideally, there should be 2 prs

  • update all the stable libs without breaking any existing functionalities
  • fix the gateway bug

Thanks again and please let me know if you can look into it otherwise, I can't make any promise on when I'll be able to fix it.

niqdev avatar Nov 28 '22 13:11 niqdev

Thanks again and please let me know if you can look into it otherwise, I can't make any promise on when I'll be able to fix it.

Hello @niqdev , Thank you for your confirmation it's a bug. Fortunately, it affects only new installations. Openwebnet still works on my phone. I can try to look into it, I don't know if i'll be able to fix it, I've never developed on Android. I'll let you know. Regards Antonio

olaquetal avatar Nov 28 '22 21:11 olaquetal

@olaquetal thanks for looking into it, I haven't looked at the code base in a while, but feel free to ask me for any help and review!

GatewayEditTextPreference should be the starting point. It's possible that is enough to bump the support libraries to solve the issue, it's definitely a regression and something changed in the recent version of android.

niqdev avatar Nov 29 '22 11:11 niqdev