Dialog improvements

Open berezh opened this issue 5 years ago • 0 comments

Currently, it opens/closes with state flag within a component. Disadvantages:

need to create additional flag in redux store to handle case the form successfully submitted, subscribe it and if it true - close the dialog. This hack makes app complicated and increases possibility to get a but.
dialog can be opened/closed only from specific component by subscribing state flag

To resolve above need to move opeding/closing to redux action. Example here - https://github.com/openware/baseapp/pull/381/commits/a0a1baebb9870a190a4e737c0033c8ae7b9e4180#diff-731b906bcd8593e0a5402f1657db9a50bc9066ce8bbd3b37c7760071098e6fb8R12

Dec 03 '20 18:12 berezh