framework icon indicating copy to clipboard operation
framework copied to clipboard

Hook loading does not allow relative importing

Open JeffreyDevloo opened this issue 6 years ago • 2 comments

All 'plugin' alike systems within the framework use imp.load and check for decorator metadata to load in the dynamic configurable function. Because imp.load loads a single file, not a module, relative importing is not possible.

I'd recommend loading plugins differently: specifying plugin directories for all types and loading them usingimportlib

JeffreyDevloo avatar Feb 15 '19 13:02 JeffreyDevloo

implementation of importlib fixed by:

https://github.com/openvstorage/framework-extensions/pull/209 https://github.com/openvstorage/framework/pull/2266

Package information: openvstorage-2.13.5-dev.1551342559.9291142

sjovdnbos avatar Feb 26 '19 16:02 sjovdnbos

Aftermath brought update issues.

Fixed by:

https://github.com/openvstorage/framework/pull/2268 https://github.com/openvstorage/framework-extensions/pull/211

sjovdnbos avatar Mar 01 '19 10:03 sjovdnbos