Unit test the add vpool code

Open JeffreyDevloo opened this issue 8 years ago • 3 comments

With the upcoming changes to add vpool, the code will be chopped up into pieces. This would be the ideal time to also provide unit tests.

Nov 07 '17 10:11 JeffreyDevloo

Is this something you can/want to pickup now? How are you validating the big PR now? Manually?

Dec 18 '17 10:12 wimpers

Can you add an estimate?

Dec 18 '17 10:12 wimpers

No need to pick it up now as the PR is done completely by manual testing. This would also just help us in future changes to the code

I'd suggest to add this once reconfigure vpool would land (as it might break the add_vpool a bit) Estimation: 3days

Jan 09 '18 15:01 JeffreyDevloo