training_extensions icon indicating copy to clipboard operation
training_extensions copied to clipboard

Register signal handler for mp.Manager in MemCacheHandlerForMP

Open eunwoosh opened this issue 2 years ago • 1 comments

Summary

This PR registers signal handler for mp.Manager in MemCacheHandlerForMP. If signal handler doesn't exist, manager process remains alive even if main process is killed by signal. It applied way implemented in #2912

How to test

Checklist

  • [x] I have added unit tests to cover my changes.​
  • [ ] I have added integration tests to cover my changes.​
  • [ ] I have added e2e tests for validation.
  • [ ] I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • [ ] I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • [ ] I have linked related issues.

License

  • [x] I submit my code changes under the same Apache License that covers the project. Feel free to contact the maintainers if that's a concern.
  • [x] I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

eunwoosh avatar Jan 12 '24 02:01 eunwoosh

@vinnamkim I implemented again based on your comments. Could you check again?

eunwoosh avatar Jan 15 '24 03:01 eunwoosh