【PaddlePaddle Hackathon 3】Add Paddle box_coder operator
Details:
add box_coder operation in Paddle front end
Reference:
https://github.com/PaddlePaddle/Paddle/blob/98f8fa4cb3d7b9c14c1897f2716249a54c44f8be/paddle/phi/kernels/cpu/box_coder.cc The paddle documents are different with source code: https://www.paddlepaddle.org.cn/documentation/docs/en/1.8/api/layers/box_coder.html
uni-test passed

@OpenVINO-dev-contest Could you please take a look? Thanks!
@OpenVINO-dev-contest Could you please take a look? Thanks!
Thanks for your contribution. We will review it ASAP.
@ceciliapeng2011 Could you please review?
Please fix clang format error.
It could automatically fixed with steps -
- apt install clang-format-9
- enable clang with cmake option: -DENABLE_CLANG_FORMAT=ON
- make clang_format_fix_all
Then submit PR again.
@ceciliapeng2011 How can I trigger the code style check?
@ceciliapeng2011 How can I trigger the code style check?
I did it for you.
@ceciliapeng2011 Hi, I'm wondering which version of paddle used in ci test.
@ceciliapeng2011 Hi, I'm wondering which version of paddle used in ci test.
paddle 2.1.0
@ceciliapeng2011 Hi, I find out that the following dygraph tests after the first one would fail, even though all the test settings are same.
I would suggest to submit the static shape support in this PR. And for dynamic shape situations, if the problem is still there and cannot catch up the deadline, we could solve it in a separate PR. So just comment the code lines and leave it there.
I find that the openvino-lin and openvino-win passed, it seems the problem is deu to my local develop environment?
I would suggest to submit the static shape support in this PR. And for dynamic shape situations, if the problem is still there and cannot catch up the deadline, we could solve it in a separate PR. So just comment the code lines and leave it there.
I find that the
openvino-linandopenvino-winpassed, it seems the problem is deu to my local develop environment?
They are just building pass. Paddle FE UT is under "ci/jenkins". Please -
- comment out dynamic test cases. let's make sure static shape cases pass first.
- fix clang-format errors.
Then I will trigger ci/jenkins again.
I would suggest to submit the static shape support in this PR. And for dynamic shape situations, if the problem is still there and cannot catch up the deadline, we could solve it in a separate PR. So just comment the code lines and leave it there.
I find that the
openvino-linandopenvino-winpassed, it seems the problem is deu to my local develop environment?They are just building pass. Paddle FE UT is under "ci/jenkins". Please -
- comment out dynamic test cases. let's make sure static shape cases pass first.
- fix clang-format errors.
Then I will trigger ci/jenkins again.
done.
I use vscode for code formatting, but it still can not pass.
@ceciliapeng2011 Can you trigger ci/jenkins first to see if the static tests can pass. I will resovle code style problem later.
I use vscode for code formatting, but it still can not pass.
diff --git a/src/frontends/paddle/src/op_table.cpp b/src/frontends/paddle/src/op_table.cpp
index 50608492..530d4165 100644
--- a/src/frontends/paddle/src/op_table.cpp
+++ b/src/frontends/paddle/src/op_table.cpp
@@ -111,7 +111,7 @@ std::map<std::string, CreatorFunction> get_supported_ops() {
{"bilinear_interp_v2", op::bilinear_interp_v2},
{"bilinear_interp", op::bilinear_interp_v2},
{"bmm", op::matmul},
- {"box_coder", op::box_coder}, **<**a invisible space here!**>**
+ {"box_coder", op::box_coder},
{"cast", op::cast},
{"clip", op::clip},
{"concat", op::concat},
Hi @Asthestarsfalll can you help to fix the format issue ?
Hi @Asthestarsfalll can you help to fix the format issue ?
Done.
@ceciliapeng2011 HI, can you trigger ci/jenkins for me? Thanks!
@ceciliapeng2011 Hi, I'm wondering that why the ci can not pass. I can't see details about ci/jenkins.
Can you please rebase and resolve the conflicts? Thanks. @Asthestarsfalll
Can you please rebase and resolve the conflicts? Thanks. @Asthestarsfalll
Done
@ceciliapeng2011 HI, can you trigger ci/jenkins for me? Thanks!
Since this PR has been suspended for nearly two months, I really want to figure out the reason of CI failure.Could you please give me some prompts in this situation? Thanks! @ceciliapeng2011 @ilyachur
Since this PR has been suspended for nearly two months, I really want to figure out the reason of CI failure.Could you please give me some prompts in this situation? Thanks!
I am keeping an eye on it. Should be okay after manually triggering the private CI.