openvino icon indicating copy to clipboard operation
openvino copied to clipboard

【PaddlePaddle Hackathon 3】Add Paddle box_coder operator

Open Asthestarsfalll opened this issue 3 years ago • 17 comments

Details:

add box_coder operation in Paddle front end

Reference:

https://github.com/PaddlePaddle/Paddle/blob/98f8fa4cb3d7b9c14c1897f2716249a54c44f8be/paddle/phi/kernels/cpu/box_coder.cc The paddle documents are different with source code: https://www.paddlepaddle.org.cn/documentation/docs/en/1.8/api/layers/box_coder.html

uni-test passed

image

Asthestarsfalll avatar Aug 02 '22 08:08 Asthestarsfalll

@OpenVINO-dev-contest Could you please take a look? Thanks!

Asthestarsfalll avatar Aug 03 '22 10:08 Asthestarsfalll

@OpenVINO-dev-contest Could you please take a look? Thanks!

Thanks for your contribution. We will review it ASAP.

openvino-dev-samples avatar Aug 04 '22 02:08 openvino-dev-samples

@ceciliapeng2011 Could you please review?

yuxu42 avatar Aug 04 '22 05:08 yuxu42

Please fix clang format error.

It could automatically fixed with steps -

  1. apt install clang-format-9
  2. enable clang with cmake option: -DENABLE_CLANG_FORMAT=ON
  3. make clang_format_fix_all

Then submit PR again.

ceciliapeng2011 avatar Aug 04 '22 06:08 ceciliapeng2011

@ceciliapeng2011 How can I trigger the code style check?

Asthestarsfalll avatar Aug 04 '22 14:08 Asthestarsfalll

@ceciliapeng2011 How can I trigger the code style check?

I did it for you.

ceciliapeng2011 avatar Aug 05 '22 09:08 ceciliapeng2011

@ceciliapeng2011 Hi, I'm wondering which version of paddle used in ci test.

Asthestarsfalll avatar Aug 12 '22 03:08 Asthestarsfalll

@ceciliapeng2011 Hi, I'm wondering which version of paddle used in ci test.

paddle 2.1.0

ceciliapeng2011 avatar Aug 18 '22 08:08 ceciliapeng2011

@ceciliapeng2011 Hi, I find out that the following dygraph tests after the first one would fail, even though all the test settings are same.

Asthestarsfalll avatar Sep 08 '22 10:09 Asthestarsfalll

I would suggest to submit the static shape support in this PR. And for dynamic shape situations, if the problem is still there and cannot catch up the deadline, we could solve it in a separate PR. So just comment the code lines and leave it there.

I find that the openvino-lin and openvino-win passed, it seems the problem is deu to my local develop environment?

Asthestarsfalll avatar Sep 13 '22 09:09 Asthestarsfalll

I would suggest to submit the static shape support in this PR. And for dynamic shape situations, if the problem is still there and cannot catch up the deadline, we could solve it in a separate PR. So just comment the code lines and leave it there.

I find that the openvino-lin and openvino-win passed, it seems the problem is deu to my local develop environment?

They are just building pass. Paddle FE UT is under "ci/jenkins". Please -

  1. comment out dynamic test cases. let's make sure static shape cases pass first.
  2. fix clang-format errors.

Then I will trigger ci/jenkins again.

ceciliapeng2011 avatar Sep 19 '22 06:09 ceciliapeng2011

I would suggest to submit the static shape support in this PR. And for dynamic shape situations, if the problem is still there and cannot catch up the deadline, we could solve it in a separate PR. So just comment the code lines and leave it there.

I find that the openvino-lin and openvino-win passed, it seems the problem is deu to my local develop environment?

They are just building pass. Paddle FE UT is under "ci/jenkins". Please -

  1. comment out dynamic test cases. let's make sure static shape cases pass first.
  2. fix clang-format errors.

Then I will trigger ci/jenkins again.

done.

I use vscode for code formatting, but it still can not pass.

Asthestarsfalll avatar Sep 19 '22 08:09 Asthestarsfalll

@ceciliapeng2011 Can you trigger ci/jenkins first to see if the static tests can pass. I will resovle code style problem later.

Asthestarsfalll avatar Sep 20 '22 04:09 Asthestarsfalll

I use vscode for code formatting, but it still can not pass.

diff --git a/src/frontends/paddle/src/op_table.cpp b/src/frontends/paddle/src/op_table.cpp
index 50608492..530d4165 100644
--- a/src/frontends/paddle/src/op_table.cpp
+++ b/src/frontends/paddle/src/op_table.cpp
@@ -111,7 +111,7 @@ std::map<std::string, CreatorFunction> get_supported_ops() {
             {"bilinear_interp_v2", op::bilinear_interp_v2},
             {"bilinear_interp", op::bilinear_interp_v2},
             {"bmm", op::matmul},
-            {"box_coder", op::box_coder}, **<**a invisible space here!**>**
+            {"box_coder", op::box_coder},
             {"cast", op::cast},
             {"clip", op::clip},
             {"concat", op::concat},

ceciliapeng2011 avatar Sep 20 '22 07:09 ceciliapeng2011

Hi @Asthestarsfalll can you help to fix the format issue ?

openvino-dev-samples avatar Sep 21 '22 07:09 openvino-dev-samples

Hi @Asthestarsfalll can you help to fix the format issue ?

Done.

Asthestarsfalll avatar Sep 21 '22 07:09 Asthestarsfalll

@ceciliapeng2011 HI, can you trigger ci/jenkins for me? Thanks!

Asthestarsfalll avatar Sep 22 '22 05:09 Asthestarsfalll

@ceciliapeng2011 Hi, I'm wondering that why the ci can not pass. I can't see details about ci/jenkins.

Asthestarsfalll avatar Oct 17 '22 06:10 Asthestarsfalll

Can you please rebase and resolve the conflicts? Thanks. @Asthestarsfalll

ceciliapeng2011 avatar Nov 06 '22 00:11 ceciliapeng2011

Can you please rebase and resolve the conflicts? Thanks. @Asthestarsfalll

Done

Asthestarsfalll avatar Nov 06 '22 05:11 Asthestarsfalll

@ceciliapeng2011 HI, can you trigger ci/jenkins for me? Thanks!

Asthestarsfalll avatar Nov 07 '22 03:11 Asthestarsfalll

Since this PR has been suspended for nearly two months, I really want to figure out the reason of CI failure.Could you please give me some prompts in this situation? Thanks! @ceciliapeng2011 @ilyachur

Asthestarsfalll avatar Nov 16 '22 05:11 Asthestarsfalll

Since this PR has been suspended for nearly two months, I really want to figure out the reason of CI failure.Could you please give me some prompts in this situation? Thanks!

I am keeping an eye on it. Should be okay after manually triggering the private CI.

ceciliapeng2011 avatar Nov 22 '22 01:11 ceciliapeng2011