nncf icon indicating copy to clipboard operation
nncf copied to clipboard

[Good First Issue][NNCF]: Remove compress_to_fp16=False from examples

Open alexsu52 opened this issue 1 year ago • 2 comments

Context

Using compress_to_fp16=False when saving a compressed/quantized OpenVINO model is no longer required following changes to OpenVINO https://github.com/openvinotoolkit/openvino/pull/23609 that are included in the OpenVINO 2024.1.0 release.

This issue suggests removing compress_to_fp16=False from the examples to simplify the examples.

Example of using compress_to_fp16=False in example: https://github.com/openvinotoolkit/nncf/blob/daec271ae331803681fad433f0d4297c64a3d136/examples/post_training_quantization/openvino/mobilenet_v2/main.py#L145

What needs to be done?

  • Removing compress_to_fp16=False attribute when saving a compressed/quantized OpenVINO model in examples
  • Check that these changes do not change metrics of the examples. Example tests should pass.

Example Pull Requests

No response

Resources

Contact points

@alexsu52

Ticket

ref: 137146

alexsu52 avatar May 06 '24 06:05 alexsu52

Hello, I'm new to contributing, can i take this one? I'd be happy to work on this project!

truhinnm avatar May 12 '24 22:05 truhinnm

Hello @truhinnm! Thank you for your interest in our project. I assigned to you this issue.

If you have any questions let me know.

alexsu52 avatar May 13 '24 04:05 alexsu52

Thanks for the contribution https://github.com/openvinotoolkit/nncf/pull/2682!

alexsu52 avatar May 24 '24 09:05 alexsu52