openvenues
node-postal does not build on nodejs versions >10.x (see pull request #25)
I tried installing node-postal on the latest LTS version of node (v12.18.3) and get the following errors (it builds and works fine on node v10.x). I've tried every solution that comes up on a Google search for this error and still get the same result. This is on Macos Catalina v10.15.6
19 warnings and 2 errors generated.
make: *** [Release/obj.target/expand/src/expand.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/xxxxx/.nvm/versions/node/v12.18.3/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack at ChildProcess.emit (events.js:315:20)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.6.0
gyp ERR! command "/Users/xxxxx/.nvm/versions/node/v12.18.3/bin/node" "/Users/xxxxx/.nvm/versions/node/v12.18.3/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/xxxxx/dev/libtest/node_modules/node-postal
gyp ERR! node -v v12.18.3
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN [email protected] No description
npm WARN [email protected] No repository field.
I just noticed that @kembuco has already submitted a pull request #25 to fix this. I tested it today and it works on both node 12.x and 14.x.
Hey @albarrentine,
Would you be interested in adding me and/or @missinglink as maintainers of node-postal? We use libpostal through Node.js quite heavily with Pelias to this day, and we'd be happy to take on the task of reviewing and merging PRs to keep node-postal up to date with the latest changes in Node.js. Let us know or shoot me an email :)
