ucx icon indicating copy to clipboard operation
ucx copied to clipboard
verified publisher icon openucx

UCP/PROTOV2: Don't depend on NO_IMM_CMPL for DATATYPE checks

Open tvegas1 opened this issue 2 years ago • 3 comments

What

Check datatype field independently from no immediate completion flag.

Why ?

Reported by #9626.

tvegas1 avatar Feb 20 '24 09:02 tvegas1

seems that UCP_OP_ATTR_FLAG_NO_IMM_CMPL is not really supported for put_nbx can you pls fix it in this pr then?

it is supported inside ucp_put_send_short() so we should be good i think.

tvegas1 avatar Feb 20 '24 10:02 tvegas1

seems that UCP_OP_ATTR_FLAG_NO_IMM_CMPL is not really supported for put_nbx can you pls fix it in this pr then?

it is supported inside ucp_put_send_short() so we should be good i think.

indeed, then can we move attr_mask initialization to protov1 section to avoid unneeded overhead for protov2?

brminich avatar Feb 20 '24 11:02 brminich

indeed, then can we move attr_mask initialization to protov1 section to avoid unneeded overhead for protov2?

makes sense, removed it altogether.

tvegas1 avatar Feb 20 '24 12:02 tvegas1

@tvegas1 can you pls squash?

yosefe avatar Feb 22 '24 13:02 yosefe