opentracing-javascript

opentracing-javascript copied to clipboard

I'm struggling to see how to manually set a span's parent in the JS library ``` var tracer = tracingManager.getTracer(); const appStartupSpan = tracer.startSpan("AppStartup"); appStartupSpan.addEvent("IronHide starting"); // Some time later...

Azim-Palmer

MockTracer._allocSpan is private and can't be overwritten

2

MockTracer._allocSpan is private and can't be overwritten - so trace can't be fully customized. Should be protected.

oranoran

Span tag values should be `string`s, `boolean`s or `number`s

2

Hi, > A set of zero or more key:value Span Tags. The keys must be strings. The values may be strings, bools, or numeric types. > > -- https://github.com/opentracing/specification/blob/master/specification.md ##...

chpio

ScopeManager

2

Addresses #112 See https://github.com/opentracing/specification/blob/f7ca62c9/rfc/scope_manager.md ## Continuation passing style I first tried adhering to the draft RFC ([somewhat working code](https://github.com/rivethealth/opentracing-javascript/commit/13fc56cd9fd5ad45d02a1f2a8454570f0db381d1)), but it got clumsy, particularly for the Zone.js implementation. Just about...

pauldraper

`__esModule` is `true` while no default export provided, breaks interoperability

2

opentracing-javascript does not work with NodeJS in _experimental-modules_ mode when webpack is involved. test.js ``` import opentracing from 'opentracing'; console.log(opentracing.globalTracer()); ``` webpack.config.cjs ``` const path = require('path'); const nodeExternals =...

sdavids

How do I trace requests from the browser?

4

I'm writing here because I've looked at most of the available options, and want to make sure I don't miss anything before I start implementing stuff on my own. We...

gioragutt

I started writing a couple of unit tests using `MockTracer`, and I see that it does not propagate tags passed to `startSpan` to the created `MockSpan`. I'll create a PR...

gioragutt

trace should expose close function

1

==== JS stack trace ========================================= 0: ExitFrame [pc: 0x55f7a153eef9] Security context: 0x26f2f4a808a1 1: /* anonymous */ [0x225ce0ec43c1] ..........client/dist/src/reporters/remote_reporter.js:~66] [pc=0x530c1d0d7cc](this=0x225ce0ec9b01 ) 2: listOnTimeout(aka listOnTimeout) [0x1089c7033d69] [internal/timers.js:~480] [pc=0x530c210d12d](this=0x0f1cd8bc04a9 ,... FATAL ERROR: Ineffective...

wzhai-hub

add tracer close

1

==== JS stack trace ========================================= 0: ExitFrame [pc: 0x55f7a153eef9] Security context: 0x26f2f4a808a1 1: /* anonymous */ [0x225ce0ec43c1] ..........client/dist/src/reporters/remote_reporter.js:~66] [pc=0x530c1d0d7cc](this=0x225ce0ec9b01 ) 2: listOnTimeout(aka listOnTimeout) [0x1089c7033d69] [internal/timers.js:~480] [pc=0x530c210d12d](this=0x0f1cd8bc04a9 ,... FATAL ERROR: Ineffective...

wzhai-hub

Creating a span via `new Span` will almost never do what folks intend, especially if they have a non noop tracer. I appreciate that doing this would make the noop...

lcapaldo