opentracing-contrib
Library silently enables Async
The configuration class DefaultAsyncAutoConfiguration enables @Async by using @EnableAsync. Is this a good pattern? I didn't expected that the library for instrumenting code is activating this functionality (per default). I would expect that the library set's up a proper configuration but doesn't enable it.
I have stumpled over this issue because we deactivated @Async for one environment and the application failed because reference threadpools have not been set-up. Took me some while to figer out what's going wrong.
Is async enabled even if opentracing.spring.cloud.async.enabled is set to false? This property is defined on DefaultAsyncAutoConfiguration. The other question is if we can enable async programmatically.
This issue is still valid and yes setting opentracing.spring.cloud.async.enabled to false keeps a non-Async application that way.
