Validator cut [WIP]

[open-junius]

Description

It will allow the subnet owner to set the validator cut during emission.

Related Issue(s)

• Closes #[issue number]

Type of Change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation update
• [ ] Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

[Swamination-Yuma]

Where are these coming from? Two days ago, we were enabling a childkey recycling of 18%, then it was cancelled. Now placing vali dividends in subnet hands? Is there any public discourse on this?

[bdmason]

Where are these coming from? Two days ago, we were enabling a childkey recycling of 18%, then it was cancelled. Now placing vali dividends in subnet hands? Is there any public discourse on this?

It helps shitnets prop up their token prices.

[shibshib]

@open-junius is there a limit to how high the cut can be? There should be.

[open-junius]

@open-junius is there a limit to how high the cut can be? There should be. Yes, we need to set the min/max value for the cut. The PR still is WIP, will clarify more details about it.

[dougsillars]

There are 2 places in run coinbase where the vali/miner ratio is mentioned.

You got the div(2), but missed the multiply(0.5)

Please look at line 211, and update that as well.

[open-junius]

There are 2 places in run coinbase where the vali/miner ratio is mentioned.

You got the div(2), but missed the multiply(0.5)

Please look at line 211, and update that as well.

It is for the root alpha, I am not sure if the cut also should be applied to it. will clarify the requirement. Thank for point it out.

[dougsillars]

There are 2 places in run coinbase where the vali/miner ratio is mentioned. You got the div(2), but missed the multiply(0.5) Please look at line 211, and update that as well.

It is for the root alpha, I am not sure if the cut also should be applied to it. will clarify the requirement. Thank for point it out.

if you don't account for it - the incorrect amount of alpha will be deducted for the root stakeholders, and the math won't sum correctly.

it will also let us close an issue: https://github.com/opentensor/subtensor/issues/1725

[Swamination-Yuma]

@open-junius is there a limit to how high the cut can be? There should be. Yes, we need to set the min/max value for the cut. The PR still is WIP, will clarify more details about it.

This was not answered specifically, nor was this communicated to be included soon. This has potential for significant arbitrary and unpredictable impact to the incentive to validate and is worthy of more discussion and likely a vote.

[open-junius]

There are 2 places in run coinbase where the vali/miner ratio is mentioned. You got the div(2), but missed the multiply(0.5) Please look at line 211, and update that as well.

It is for the root alpha, I am not sure if the cut also should be applied to it. will clarify the requirement. Thank for point it out.

if you don't account for it - the incorrect amount of alpha will be deducted for the root stakeholders, and the math won't sum correctly.

it will also let us close an issue: #1725 You are right, it is hardcoded when computing root alpha and pending. I find out a solution as https://github.com/opentensor/subtensor/pull/2052/files#diff-95876de84995c6acb815ebc924523f0584ba6cbfab7da12b258a5393ea2541ebR687 to update the incentive and dividends according to the validator cut.