platform icon indicating copy to clipboard operation
platform copied to clipboard

fix(sdk)!: CreateNanoTDF not using functional options

Open sujankota opened this issue 1 year ago • 7 comments

Resolves #1042

sujankota avatar Sep 06 '24 22:09 sujankota

[!WARNING] This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description.

github-actions[bot] avatar Sep 06 '24 22:09 github-actions[bot]

[!WARNING] This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description.

github-actions[bot] avatar Sep 09 '24 14:09 github-actions[bot]

[!WARNING] This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description.

github-actions[bot] avatar Sep 09 '24 14:09 github-actions[bot]

[!WARNING] This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description.

github-actions[bot] avatar Sep 09 '24 14:09 github-actions[bot]

[!WARNING] This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description.

github-actions[bot] avatar Sep 09 '24 14:09 github-actions[bot]

IMO we should add a new function, e.g. CreateNanoTDFOpts(), instead of modifying the existing function; this will allow us to deprecate the current behavior and upgrade without breaking anyone downstream

dmihalcik-virtru avatar Sep 09 '24 18:09 dmihalcik-virtru

See suggestion: https://github.com/opentdf/platform/pull/1534

dmihalcik-virtru avatar Sep 10 '24 13:09 dmihalcik-virtru

Let's rethink this as part of a unified *TDF API, that can do both nano and z/base TDF together

dmihalcik-virtru avatar Jan 29 '25 14:01 dmihalcik-virtru