OpenStudioApplication icon indicating copy to clipboard operation
OpenStudioApplication copied to clipboard

Unable to delete subsurfaces in spaces, subsurfaces tab

Open Ski90Moo opened this issue 3 years ago • 2 comments

Issue overview

Unable to delete subsurfaces in the spaces, subsurfaces tab 2022-06-29

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudioApplication ( 2022-06-29 (2) if using an intermediate build, include SHA):

Context

Ski90Moo avatar Jun 29 '22 15:06 Ski90Moo

This is the line that would enable that: https://github.com/openstudiocoalition/OpenStudioApplication/blob/develop/src/openstudio_lib/SpacesSubsurfacesGridView.cpp#L169

I don't think we want to enable Add, Copy, or Purge for SubSurfaces. Remove could be acceptable but it risks removing matched SubSurfaces in different zones. I suppose in that case we could remove both SubSurfaces?

Note that the same rules apply for Surfaces: https://github.com/openstudiocoalition/OpenStudioApplication/blob/develop/src/openstudio_lib/SpacesSurfacesGridView.cpp#L99

Deleting a Surface from a valid would leave a hole in the building so I'm not sure we want that.

macumber avatar Jun 30 '22 04:06 macumber

I wanted to use this as an easy way to remove all interior doors or windows as there were a lot of vertex mismatch errors associated with the interior walls with these subsurfaces.

If you are removing a subsurface and it has a match, you will likely want to remove both anyway.

This function used to be available on 2.9.1.

Dan Macumber @.***> schrieb am Mi. 29. Juni 2022 um 9:20 PM:

This is the line that would enable that: https://github.com/openstudiocoalition/OpenStudioApplication/blob/develop/src/openstudio_lib/SpacesSubsurfacesGridView.cpp#L169

I don't think we want to enable Add, Copy, or Purge for SubSurfaces. Remove could be acceptable but it risks removing matched SubSurfaces in different zones. I suppose in that case we could remove both SubSurfaces?

Note that the same rules apply for Surfaces: https://github.com/openstudiocoalition/OpenStudioApplication/blob/develop/src/openstudio_lib/SpacesSurfacesGridView.cpp#L99

Deleting a Surface from a valid would leave a hole in the building so I'm not sure we want that.

— Reply to this email directly, view it on GitHub https://github.com/openstudiocoalition/OpenStudioApplication/issues/556#issuecomment-1170738794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQUKBFGFYMKNF3JKNWRMPCTVRUOCLANCNFSM52GGBX3Q . You are receiving this because you authored the thread.Message ID: @.*** com>

-- Best Regards, Mike Lovejoy P.E. Helix Energy Partners LLC Helix, OR http://www.helix-engineers.net/ https://deref-mail.com/mail/client/aJLmMsp2k0Y/dereferrer/?redirectUrl=http%3A%2F%2Fwww.helix-engineers.net%2F P:541-379-0271

Ski90Moo avatar Jun 30 '22 04:06 Ski90Moo