minicap icon indicating copy to clipboard operation
minicap copied to clipboard

Different virtual width when running on Samsung s8

Open RameshY703 opened this issue 8 years ago • 9 comments

adb shell LD_LIBRARY_PATH=/data/local/tmp /data/local/tmp/minicap -P "1440x2960@270x480/0" PID: 23214 INFO: Using projection 1440x2960@234x480/0 INFO: (external/MY_minicap/src/minicap_24.cpp:240) Creating SurfaceComposerClient INFO: (external/MY_minicap/src/minicap_24.cpp:243) Performing SurfaceComposerClient init check INFO: (external/MY_minicap/src/minicap_24.cpp:250) Creating virtual display INFO: (external/MY_minicap/src/minicap_24.cpp:256) Creating buffer queue INFO: (external/MY_minicap/src/minicap_24.cpp:261) Creating CPU consumer INFO: (external/MY_minicap/src/minicap_24.cpp:265) Creating frame waiter INFO: (external/MY_minicap/src/minicap_24.cpp:269) Publishing virtual display INFO: (jni/minicap/JpgEncoder.cpp:64) Allocating 12789252 bytes for JPG encoder

It automatically take different virtual width than specified on samsung s8.

RameshY703 avatar Jul 03 '17 12:07 RameshY703

+1

not work well on Samsung S8. The minicap do not take the whole screen of the device.

Maybe there is something wrong with the screen resolution. The real screen resolution is 1080x2008 which is got from the java. But if I use the minicap, it always get the 1440x2960

harlentan avatar Jul 14 '17 15:07 harlentan

Does it work in STF or not?

On Fri, Jul 14, 2017 at 23:18 Harlen Tan [email protected] wrote:

+1

not work well on Samsung S8. The minicap do not take the whole screen of the device.

Maybe there is something wrong with the screen resolution. The real screen resolution is 1080x2008 which is got from the java. But if I use the minicap, it always get the 1440x2960

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openstf/minicap/issues/78#issuecomment-315386034, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-_a8rXO50oHMK00XZfG4PJ4KncPcnks5sN4YogaJpZM4OMNjN .

sorccu avatar Jul 14 '17 15:07 sorccu

Nope.

STF will also get the wrong screen display.

I test Samsung S8 in STF, it gets 1080x2008 screen resolution

harlentan avatar Jul 15 '17 03:07 harlentan

function infoFromService(id) {
      return service.getDisplay(id)
}

function readInfo(id) {
    log.info('Reading display info')
    return infoFromService(id)
        .catch(function() {
          return infoFromMinicap(id)
        })
        .then(function(properties) {
          properties.url = screenOptions.publicUrl
          return new Display(id, properties)
        })
}

The screen height & width are weird.

STF will have the priority to get display properties from STFService, which will return 1080x2008, and the 2008 is not exactly the screen height.

harlentan avatar Jul 15 '17 03:07 harlentan

@RameshY703 @harlentan I too faced the similar issue in Samsung galaxy S7 hope this helps


Resolution It's might be an issue with display settings in the device In the settings menu the under display the screen resolution make sure its set to WQHD 1440x2560

After changing the setting to WQHD , minicap virtual display is working as excepted

thulasipavankumar avatar Jul 19 '17 12:07 thulasipavankumar

That's great !

I will test it later. Thanks.

harlentan avatar Jul 20 '17 05:07 harlentan

@thulasipavankumar @sorccu

I am afraid that modify the settings of display to WQHD do not work for Galaxy S8 in STF.

Maybe I should take some time to go depth into this issue.

harlentan avatar Jul 25 '17 11:07 harlentan

@thulasipavankumar thanks that helped on my Galaxy S7!

stoefln avatar Dec 10 '18 13:12 stoefln

Following @thulasipavankumar 's advice I managed to only get one screen resolution: $ adb shell wm size

Physical size: 1440x2560

Before switching to WHQD I had black bars in the minicap stream, and wm size showed two resolutions: $ adb shell wm size

Physical size: 1440x2560 Override size: 1080x1920

stoefln avatar Dec 10 '18 13:12 stoefln