openstack.net icon indicating copy to clipboard operation
openstack.net copied to clipboard

CreateFormPostUri can cause subtle bugs

Open carolynvs opened this issue 9 years ago • 0 comments

CreateFormPostUri takes a Uri for the redirect value and if the value supplied does not have a file extension, e.g. http://example.com, Uri will quietly change it to http://example.com/. This easily leads to invalid signature exceptions because the redirect value in the form and hash are different.

Since nothing is gained by using a Uri as a parameter, I suggest switching to string when we revisit Object Storage.

carolynvs avatar Feb 17 '16 20:02 carolynvs