BIMsurfer icon indicating copy to clipboard operation
BIMsurfer copied to clipboard

setVisibility(params) not working

Open sguionni opened this issue 6 years ago • 4 comments

Hi, i'm calling the setVisibility function with params:

this._viewer.setVisibility({ ids: p_objects, visible: false });

where p_objects is the array of object oids but nothing happen, did i forgot something ?

sguionni avatar Aug 12 '19 09:08 sguionni

I have the same problem. And also key shorcut 'h' not working. Surfer version 0.0.253. If I use (useUuidAndRid = true), then work's fine.

JanoSlivka avatar Aug 12 '19 16:08 JanoSlivka

I change this line https://github.com/opensourceBIM/BIMsurfer/blob/236c2a41606a2d04a554d04e56612fb43183ba8a/viewer/viewer.js#L211 with this.settings.loaderSettings.useUuidAndRid ? fn("O" + i) : fn(i | OVERRIDE_FLAG);

It works for me.

JanoSlivka avatar Aug 13 '19 08:08 JanoSlivka

Thank for your answer i will try this. If you think it's a bug fix you can make a PR maybe.

sguionni avatar Aug 13 '19 08:08 sguionni

I don't now, but before using Uuid as identifier was used fn(i | OVERRIDE_FLAG)

JanoSlivka avatar Aug 13 '19 09:08 JanoSlivka