openslide-python icon indicating copy to clipboard operation
openslide-python copied to clipboard

Support openslide-bin

Open bgilbert opened this issue 1 year ago • 5 comments

Prefer loading OpenSlide from the openslide-bin package if available.

bgilbert avatar Mar 28 '24 17:03 bgilbert

DCO signed off :heavy_check_mark:

All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1.

openslide-bot avatar Mar 28 '24 17:03 openslide-bot

May I ask when this PR will be merged and the potential release date of openslide-python 1.4.0?

Mr-Milk avatar May 27 '24 15:05 Mr-Milk

Hopefully within the next couple months. The missing pieces for this PR are docs and error message updates, which don't affect the functionality, so while you're waiting you should be able to use a local OpenSlide Python build with this patch applied.

bgilbert avatar May 28 '24 09:05 bgilbert

I can help with the docs and the error message part if this can accelerate the release process.

Mr-Milk avatar May 28 '24 09:05 Mr-Milk

Thanks for the offer. 1.4.0 isn't only waiting for this PR, though. Type hints and some additional cleanups are also planned, and my attention is currently on some work in the main OpenSlide repo.

If you'd like to contribute the docs and error updates, feel free to submit a new PR to this repo with just those changes. If they look good, I can merge them into this branch or land them separately.

bgilbert avatar May 28 '24 10:05 bgilbert