osdctl icon indicating copy to clipboard operation
osdctl copied to clipboard

OCM-10376 | Add Limited Support Reason Override support

Open mnecas opened this issue 1 year ago • 3 comments

Right now we have new override parameters in the LSR so we can keep the LSR visible to the SRE but it can be overriden when there is support exception. The cluster status shows only active LSR, without the override.

mnecas avatar Aug 13 '24 13:08 mnecas

Hi @mnecas. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 13 '24 13:08 openshift-ci[bot]

@AlexVulaj could you PTAL?

mnecas avatar Aug 13 '24 14:08 mnecas

/ok-to-test

mjlshen avatar Sep 11 '24 12:09 mjlshen

/approve

Looks alright to me but I'd like one other set of eyes

AlexVulaj avatar Sep 11 '24 12:09 AlexVulaj

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, mnecas, NautiluX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [AlexVulaj,NautiluX]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 17 '24 06:09 openshift-ci[bot]

@mnecas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 17 '24 06:09 openshift-ci[bot]