osdctl icon indicating copy to clipboard operation
osdctl copied to clipboard

Allow reading creds as env var for account mgmt commands

Open sam-nguyen7 opened this issue 1 year ago • 5 comments

https://issues.redhat.com/browse/OSD-20603

Update osdctl account mgmt commands to use RH SSO credentials generated via https://github.com/app-sre/rh-aws-saml-login which spawns a new shell with the AWS_ACCOUNT_NAME environment variable.

sam-nguyen7 avatar Aug 08 '24 19:08 sam-nguyen7

/hold for testing assign command fails due to: error: operation error Organizations: CreateAccount, https response error StatusCode: 400, RequestID: bb0e1fda-4bed-411d-a2c4-1ad6d68594f5, AccessDeniedException: You don't have permissions to access this resource.

MR was created to add permission: https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/114730

sam-nguyen7 avatar Aug 08 '24 19:08 sam-nguyen7

/label tide/merge-method-squash

sam-nguyen7 avatar Aug 21 '24 15:08 sam-nguyen7

/hold cancel

sam-nguyen7 avatar Aug 22 '24 15:08 sam-nguyen7

@sam-nguyen7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 22 '24 21:08 openshift-ci[bot]

/lgtm

Thanks for making the changes!

iamkirkbater avatar Aug 26 '24 15:08 iamkirkbater

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, sam-nguyen7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [iamkirkbater,sam-nguyen7]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 26 '24 15:08 openshift-ci[bot]