origin icon indicating copy to clipboard operation
origin copied to clipboard

remove locator use

Open dgoodwin opened this issue 1 year ago • 2 comments

  • Restore the tests looking for excess single-second disruptions
  • Remove several uses of legacy string locators

dgoodwin avatar Feb 15 '24 15:02 dgoodwin

/retest

dgoodwin avatar Feb 26 '24 13:02 dgoodwin

@dgoodwin: This pull request references TRT-1545 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This is continued work on the structured intervals, everything has been ported to the new format but before we can remove the legacy "locator" field we need the code to stop using it. This is just a small start on porting some of those to use StructuredInterval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 01 '24 13:03 openshift-ci-robot

/retest

dgoodwin avatar Mar 11 '24 12:03 dgoodwin

/retest

DennisPeriquet avatar Mar 11 '24 20:03 DennisPeriquet

/lgtm /hold

if my comments are ok, you can hold cancel anytime.

DennisPeriquet avatar Mar 15 '24 13:03 DennisPeriquet

/hold cancel

Large chunk of work ready to go that depends on this after shift week.

dgoodwin avatar Mar 25 '24 11:03 dgoodwin

/retest-required

Remaining retests: 0 against base HEAD 200d8c320e849fc83ea3c8da21bdb7fca130be4b and 2 for PR HEAD eeef66b31c0fbb260b745ad6fc7361ba67c982e0 in total

openshift-ci-robot avatar Mar 25 '24 11:03 openshift-ci-robot

Job Failure Risk Analysis for sha: eeef66b31c0fbb260b745ad6fc7361ba67c982e0

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade IncompleteTests
Tests for this run (23) are below the historical average (413): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-csi IncompleteTests
Tests for this run (20) are below the historical average (401): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd IncompleteTests
Tests for this run (26) are below the historical average (379): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar Mar 25 '24 14:03 openshift-trt-bot

/retest

dgoodwin avatar Mar 25 '24 16:03 dgoodwin

[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator expand_less 	0s
{  1 events happened too frequently

event happened 22 times, something is wrong: namespace/openshift-kube-apiserver-operator deployment/kube-apiserver-operator hmsg/7c79ac0a72 - reason/RequiredInstallerResourcesMissing configmaps: aggregator-client-ca,check-endpoints-kubeconfig,client-ca,control-plane-node-kubeconfig, configmaps: bound-sa-token-signing-certs-9,config-9,etcd-serving-ca-9,kube-apiserver-audit-policies-9,kube-apiserver-cert-syncer-kubeconfig-9,kube-apiserver-pod-9,kubelet-serving-ca-9,sa-token-signing-certs-9 From: 18:30:58Z To: 18:30:59Z result=reject }

This one has me a little nervous, I can't see anything in here that would cause this, and it does happen albeit very rarely: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-sdn-upgrade/1770220099685322752

Main concern would be that it's something that should be allowed but no longer is due to something in this PR. We have an allowed patho for for RequiredInstallerResourcesMissing, but only for etcd operator secrets, not kube-apiserver-operator configmaps. I think the PR is probably ok but we'll re-test again.

/retest

dgoodwin avatar Mar 26 '24 11:03 dgoodwin

/test e2e-gcp-ovn-upgrade

dgoodwin avatar Mar 26 '24 17:03 dgoodwin

I don't like that this test has failed a few times on gcp-ovn:

[sig-arch] events should not repeat pathologically for ns/openshift-kube-controller-manager-operator expand_less 0s { 1 events happened too frequently

event happened 21 times, something is wrong: namespace/openshift-kube-controller-manager-operator deployment/kube-controller-manager-operator hmsg/7d714675bd - reason/RequiredInstallerResourcesMissing configmaps: aggregator-client-ca,client-ca, configmaps: cluster-policy-controller-config-34,config-34,controller-manager-kubeconfig-34,kube-controller-cert-syncer-kubeconfig-34,kube-controller-manager-pod-34,recycler-config-34,service-ca-34,serviceaccount-ca-34 From: 18:55:14Z To: 18:55:15Z result=reject }

however it's happening in periodics, just rarely... https://prow.ci.openshift.org/job-history/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-upgrade The output is identical. We do not seem to have an exception for this. I can't see how it's this PR at present.

dgoodwin avatar Apr 03 '24 11:04 dgoodwin

/test ci/prow/e2e-gcp-ovn-upgrade

dgoodwin avatar Apr 03 '24 11:04 dgoodwin

@dgoodwin: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-baremetalds-kubevirt
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-local-gateway
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 03 '24 11:04 openshift-ci[bot]

/test e2e-gcp-ovn-upgrade

dgoodwin avatar Apr 03 '24 11:04 dgoodwin

/lgtm

DennisPeriquet avatar Apr 03 '24 13:04 DennisPeriquet

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [DennisPeriquet,dgoodwin]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 03 '24 13:04 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD 568217e9b45a2d97072b71cb00469b0969e6d59d and 2 for PR HEAD 8fc92216a25b4285b7377190d21c6233f27fefbe in total

openshift-ci-robot avatar Apr 03 '24 17:04 openshift-ci-robot

/test e2e-metal-ipi-ovn-ipv6

dgoodwin avatar Apr 04 '24 11:04 dgoodwin

/retest

dgoodwin avatar Apr 04 '24 11:04 dgoodwin

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Not related to this PR.

dgoodwin avatar Apr 04 '24 14:04 dgoodwin

Job Failure Risk Analysis for sha: 8fc92216a25b4285b7377190d21c6233f27fefbe

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (101) are below the historical average (1099): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar Apr 04 '24 14:04 openshift-trt-bot

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Not related to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 04 '24 14:04 openshift-ci[bot]

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 8fc92216a25b4285b7377190d21c6233f27fefbe link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node 8fc92216a25b4285b7377190d21c6233f27fefbe link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 04 '24 14:04 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202404041343.p0.g2d18729.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.

openshift-bot avatar Apr 04 '24 19:04 openshift-bot