openshift
deploy: change imagestreams importMode to preserveOriginal only when working with multi-arch compute clusters
Following discussions around #27864, rather than changing importMode unconditionally, change it to import manifestlists only when the installed cluster has nodes of differing architectures
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Prashanth684 Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/cc @deads2k this follows up on this discussion to add the importMode option only when the cluster in question uses the multi payload (which is used by heterogeneous clusters today)
/cc @deads2k this follows up on this discussion to add the importMode option only when the cluster in question uses the multi payload (which is used by heterogeneous clusters today)
I have modified this now to actually check if the cluster has differing arch nodes to make this decision
@Prashanth684: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn-single-node-serial | 68057f9328420df20512bede95a371bcdbe1ca66 | link | false | /test e2e-aws-ovn-single-node-serial |
| ci/prow/e2e-aws-ovn-single-node | 68057f9328420df20512bede95a371bcdbe1ca66 | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 68057f9328420df20512bede95a371bcdbe1ca66 | link | false | /test e2e-aws-ovn-single-node-upgrade |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Job Failure Risk Analysis for sha: 68057f9328420df20512bede95a371bcdbe1ca66
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade | IncompleteTests Tests for this run (425) are below the historical average (2017): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
I'm still not clear on why it's a good thing that our documentation, existing blogs, and existing scripts will not be portable to heterogeneous clusters. Can we update the description to explain why this is better than making our existing collateral "just work"?
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
