openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[DRAFT] OSDOCS-11053 Removing incorrect name attribute for rosa edit mpool

Open laubai opened this issue 1 year ago • 6 comments

Version(s): 4.15+

Issue: https://issues.redhat.com/browse/OSDOCS-11053

Link to docs preview:

  • https://78480--ocpdocs-pr.netlify.app/openshift-rosa/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html
  • https://78480--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa-configuring-pid-limits.html
  • https://78480--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html

QE review:

  • [ ] QE has approved this change.

laubai avatar Jul 04 '24 08:07 laubai

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 04 '24 08:07 openshift-ci[bot]

/test all

laubai avatar Jul 04 '24 08:07 laubai

🤖 Tue Aug 06 07:23:49 - Prow CI generated the docs preview:

https://78480--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_cluster_admin/osd_nodes/osd-managing-worker-nodes.html https://78480--ocpdocs-pr.netlify.app/openshift-rosa/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html https://78480--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa-configuring-pid-limits.html https://78480--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html

ocpdocs-previewbot avatar Jul 04 '24 08:07 ocpdocs-previewbot

/test all

laubai avatar Jul 04 '24 08:07 laubai

/test all

laubai avatar Jul 04 '24 08:07 laubai

/lgtm

yuwang-RH avatar Jul 24 '24 05:07 yuwang-RH

/labels peer-review-needed

laubai avatar Jul 24 '24 08:07 laubai

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Aug 06 '24 07:08 openshift-ci[bot]

/labels peer-review-needed

laubai avatar Aug 06 '24 07:08 laubai

@laubai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 06 '24 07:08 openshift-ci[bot]

/label peer-review-needed

laubai avatar Aug 06 '24 07:08 laubai

/label peer-review-in-progress

xenolinux avatar Aug 06 '24 08:08 xenolinux

/label merge-review-needed

laubai avatar Aug 07 '24 08:08 laubai

/cherrypick enterprise-4.17

sheriff-rh avatar Aug 07 '24 12:08 sheriff-rh

/cherrypick enterprise-4.16

sheriff-rh avatar Aug 07 '24 12:08 sheriff-rh

/cherrypick enterprise-4.15

sheriff-rh avatar Aug 07 '24 12:08 sheriff-rh

@sheriff-rh: new pull request created: #80123

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sheriff-rh: new pull request created: #80124

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sheriff-rh: #78480 failed to apply on top of branch "enterprise-4.15":

Applying: OSDOCS-11053 Removing incorrect name attribute for rosa edit machinepool command
Using index info to reconstruct a base tree...
M	modules/creating-a-machine-pool-cli.adoc
M	modules/rosa-edit-objects.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/rosa-edit-objects.adoc
CONFLICT (content): Merge conflict in modules/rosa-edit-objects.adoc
Auto-merging modules/creating-a-machine-pool-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-11053 Removing incorrect name attribute for rosa edit machinepool command
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Looks like this one will also need a manual cherrypick to 4.15 @laubai

sheriff-rh avatar Aug 07 '24 12:08 sheriff-rh