openshift
Update ocp-4-15-release-notes, since there is no plan to remove icsp in future release.
SInce there is no plan to remove ICSP object hence we need to update the release notes accordingly.
From this: Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, it will be removed in a future release of this product and is not recommended for new deployments.
To this: Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in OpenShift Container Platform and continues to be supported; however, It might be removed in a future release of this product. Because it is deprecated functionality, avoid using it for new deployments.
Version(s): 4.13, 4.14, 4.15
Issue: https://issues.redhat.com/browse/OCPBUGS-36519
Link to docs preview: https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/release_notes/ocp-4-15-release-notes#ocp-4-15-nodes-icsp-idms-compatibility
OpenShift Container Platform 4.15 release notes > 1.3. New features and enhancements > 1.3.17. Nodes > 1.3.17.3. ICSP, IDMS, and ITMS are now compatible
QE review:
🤖 Thu Jul 04 12:28:57 - Prow CI generated the docs preview:
https://78465--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes.html
Hello @gauravsingh85 , Can you help with the validation on this PR to @mburke5678 and @kalexand-rh
hey @zaneb now the statement is - "it may be removed in a future release of this product and is not recommended for new deployments" Can you review once.
I'm OK with this. Note that we explicitly document this as a Tier 1 API, meaning that we have committed not to removing it within a major release. So if you want to be more specific you can say that.
@bshaw7 Are you sure you want this PR to be CP-ed only in 4.13, 4.14, and 4.15? Not to later versions? Please clarify. TY!
@Srivaralakshmi Yes only for 4.13, 4.14, and 4.15. It's not mention in 4.16 release notes.
@Srivaralakshmi we should go with below only. Instead of saying 'Do not use'
Using an ICSP object to configure repository mirroring is a deprecated feature. Deprecated functionality is still included in {product-title} and continues to be supported. However, it might be removed in a future release of this product. It is not recommended to use deprecated functionality for new deployments.
@bshaw7: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks like we need a few more acks before we can merge. I see @mburke5678 has tagged them. I am removing the merge review needed label for now.
@sheriff-rh: #78465 failed to apply on top of branch "enterprise-4.14":
Applying: Update ocp-4-15-release-notes.adoc
Using index info to reconstruct a base tree...
A release_notes/ocp-4-15-release-notes.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): release_notes/ocp-4-15-release-notes.adoc deleted in HEAD and modified in Update ocp-4-15-release-notes.adoc. Version Update ocp-4-15-release-notes.adoc of release_notes/ocp-4-15-release-notes.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update ocp-4-15-release-notes.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@sheriff-rh: #78465 failed to apply on top of branch "enterprise-4.13":
Applying: Update ocp-4-15-release-notes.adoc
Using index info to reconstruct a base tree...
A release_notes/ocp-4-15-release-notes.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): release_notes/ocp-4-15-release-notes.adoc deleted in HEAD and modified in Update ocp-4-15-release-notes.adoc. Version Update ocp-4-15-release-notes.adoc of release_notes/ocp-4-15-release-notes.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update ocp-4-15-release-notes.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.13
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Well that was silly of me to try and cherrypick - @bshaw7 you will have to manually modify 4.14 and 4.13's release notes with this text. Be sure to reference this PR in the top comment so it can be tracked.
@sheriff-rh created for 4.14 and 4.13 https://github.com/openshift/openshift-docs/pull/78638 https://github.com/openshift/openshift-docs/pull/78640