openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS-40768: Clarifying CSI driver type

Open jherrman opened this issue 1 year ago • 4 comments

Version(s): 4.15

Issue: https://issues.redhat.com/browse/CNV-40768

Link to docs preview: https://78005--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-configuring-shared-volumes-for-vms.html

QE review:

  • [ ] QE has approved this change.

jherrman avatar Jun 24 '24 21:06 jherrman

@jherrman: No Jira issue with key OSDOCS-40768 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/CNV-40768

Link to docs preview: TBA

QE review:

  • [ ] QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 24 '24 21:06 openshift-ci-robot

🤖 Thu Sep 26 12:39:07 - Prow CI generated the docs preview:

https://78005--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-configuring-shared-volumes-for-vms.html

ocpdocs-previewbot avatar Jun 24 '24 21:06 ocpdocs-previewbot

@jherrman: No Jira issue with key OSDOCS-40768 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 4.15

Issue: https://issues.redhat.com/browse/CNV-40768

Link to docs preview: https://78005--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-configuring-shared-volumes-for-vms.html

QE review:

  • [ ] QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 03 '24 13:07 openshift-ci-robot

@jherrman: No Jira issue with key OSDOCS-40768 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 4.15 and later

Issue: https://issues.redhat.com/browse/CNV-40768

Link to docs preview: https://78005--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-configuring-shared-volumes-for-vms.html

QE review:

  • [ ] QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 25 '24 10:09 openshift-ci-robot

/label peer-review-needed

jherrman avatar Oct 14 '24 16:10 jherrman

/lgtm

mhenriks avatar Oct 31 '24 20:10 mhenriks

/lgtm

alicefr avatar Nov 04 '24 08:11 alicefr

@kgoldbla: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Nov 04 '24 09:11 openshift-ci[bot]

/label merge-review-needed

jherrman avatar Nov 04 '24 15:11 jherrman

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Nov 04 '24 17:11 openshift-merge-robot

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Nov 04 '24 17:11 openshift-ci[bot]

@jherrman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 8068cd1dc6e2cb930362b4eb565a814a8b23884b link true /test validate-asciidoc
ci/prow/validate-portal 8068cd1dc6e2cb930362b4eb565a814a8b23884b link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 04 '24 17:11 openshift-ci[bot]

@jherrman: No Jira issue with key OSDOCS-40768 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 4.15 and later

Issue: https://issues.redhat.com/browse/CNV-40768

Link to docs preview: https://78005--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-configuring-shared-volumes-for-vms.html

QE review:

  • [x] QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 04 '24 17:11 openshift-ci-robot

Looks like the sync + squash + force push combo broke the source, will create a fresh branch (and PR) with the original changes

jherrman avatar Nov 04 '24 17:11 jherrman

To be merged via https://github.com/openshift/openshift-docs/pull/84439 (hopefully)

jherrman avatar Nov 04 '24 17:11 jherrman

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Feb 03 '25 01:02 openshift-bot

The changes have been applied via https://github.com/openshift/openshift-docs/pull/84439 -> closing this PR, too.

jherrman avatar Feb 03 '25 07:02 jherrman