openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

HCIDOCS-188: Scaling UPI cluster with BMO doesn't explain host networ…

Open kdrake20 opened this issue 1 year ago • 54 comments

Fixes: HCIDOCS-188

For: OCP 4.13+

Preview

  • https://77264--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/scaling-a-user-provisioned-cluster-with-the-bare-metal-operator.html#upi-provisioning-new-hosts-in-a-upi-cluster_scaling-a-user-provisioned-cluster-with-the-bare-metal-operator

Approvals - /lgtm:

  • [x] SME
  • [ ] QE
  • [ ] Peer Review

kdrake20 avatar Jun 10 '24 18:06 kdrake20

@kdrake20: This pull request references HCIDOCS-188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-188

For: Version 4.13+

Preview

Signed-off-by: Katie Drake [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 10 '24 18:06 openshift-ci-robot

@kdrake20: This pull request references HCIDOCS-188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-188

For: Version 4.13+

Preview

Signed-off-by: Katie Drake [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 10 '24 18:06 openshift-ci-robot

Who: Ramon Acedo, SME Dmitry Tantsur, SME Pedro Jose Amoedo Martinez, QE

Timestamp: June 10, 2024 2:18PM

Summary: Hello! Could I please get an SME and QE review of this content? Please provide feedback directly in the PR. Comment /lgtm if no changes are required. Thank you! Jira PR Preview

kdrake20 avatar Jun 10 '24 18:06 kdrake20

🤖 Fri Dec 06 20:28:30 - Prow CI generated the docs preview:

https://77264--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/scaling-a-user-provisioned-cluster-with-the-bare-metal-operator.html

ocpdocs-previewbot avatar Jun 10 '24 18:06 ocpdocs-previewbot

@kdrake20: This pull request references HCIDOCS-188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-188

For: Version 4.13+

Preview

Signed-off-by: Katie Drake [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 10 '24 18:06 openshift-ci-robot

/label peer-review-needed

kdrake20 avatar Jun 10 '24 18:06 kdrake20

/label peer-review-in-progress /remove-label peer-review-needed

shipsing avatar Jun 11 '24 10:06 shipsing

/label peer-review-done

@kdrake20, Provided some suggestions and added some queries for clarification. Overall, the procedure does not look very clear. I think reviews from SME and QE would definitely help.

Once all the reviews are done and suggestions are implemented, i would suggest to go for another peer review of this PR.

shipsing avatar Jun 11 '24 12:06 shipsing

Who: @racedo, SME @dtantsur, SME @pamoedom, QE

Timestamp: June 13, 2024 11:58 AM

Summary: Hello! Could I please get an SME and QE review of this content? Please provide feedback directly in the PR. Comment /lgtm if no changes are required. Thank you! Jira PR Preview

kdrake20 avatar Jun 13 '24 15:06 kdrake20

Made the majority of Shipra's suggested changes. Will verify her questions with SMEs.

kdrake20 avatar Jun 20 '24 16:06 kdrake20

Who: @racedo, SME @dtantsur, SME

Timestamp: June 24, 2024 3:13 PM

Summary: Hello! Could I please get an SME review of this content? Please provide feedback directly in the PR. Comment /lgtm if no changes are required. Thank you! Jira https://github.com/openshift/openshift-docs/pull/77264 Preview

Next Steps:

  • [x] Receive /lgtm from SME

kdrake20 avatar Jun 24 '24 19:06 kdrake20

/rebuild

kdrake20 avatar Jul 19 '24 16:07 kdrake20

Who: @dtantsur, SME @pamoedom, QE

Timestamp: July 19, 2024 12:50 PM

Summary: Dmitry, I've made your requested changes. Could I please get an SME and QE review of this content? Please provide feedback directly in the PR. Comment /lgtm if no changes are required. Thank you! Jira https://github.com/openshift/openshift-docs/pull/77264 Preview

Next Steps:

  • [ ] Receive /lgtm from SME and QE

kdrake20 avatar Jul 19 '24 16:07 kdrake20

@kdrake20 This will require peer review again because of all the changes.

apinnick avatar Jul 21 '24 09:07 apinnick

/remove-label peer-review-done /remove-label peer-review-in-progress

kdrake20 avatar Jul 23 '24 19:07 kdrake20

/label peer-review-needed

kdrake20 avatar Jul 23 '24 19:07 kdrake20

@kdrake20 A few comments. Otherwise LGTM

mburke5678 avatar Jul 23 '24 21:07 mburke5678

Contact Method: #forum-assisted-installer-qe Timestamp: July 26, 2024 1:22 PM Summary: Requested QE review.

kdrake20 avatar Jul 26 '24 17:07 kdrake20

Changes LGTM

mburke5678 avatar Jul 26 '24 18:07 mburke5678

Contact Method: #forum-ecosystem-qe Timestamp: July 29, 2024 1:19 PM Summary: Requested QE review.

kdrake20 avatar Jul 30 '24 14:07 kdrake20

Who: @dtantsur, SME Timestamp: August 13, 2024 2:25 PM Summary: Confirming preprovisioningNetworkDataName field for DHCP section of the content.

Note: Dmitry is on PTO until 8/19.

kdrake20 avatar Aug 13 '24 18:08 kdrake20

I removed the peer-review-done label because this PR will require another peer review before it can be merged.

apinnick avatar Aug 14 '24 07:08 apinnick

Who: @dtantsur, SME/QE @sgoveas, QE

Timestamp: September 27, 2024 4:16 PM Summary: I’ve made your requested edits. Could you please review the content and provide an /lgtm (or feedback on changes)? I'll need both an SME and QE /lgtm in order to merge content. Thank you!

kdrake20 avatar Sep 27 '24 20:09 kdrake20

Timestamp: September 27, 2024 4:23 PM Summary: Requested peer review in #forum-hci-docs-review

kdrake20 avatar Sep 27 '24 20:09 kdrake20

Who: @dtantsur, SME @sgoveas, QE

Timestamp: September 30, 2024 1:11 PM Summary: I’ve made the requested edits. Could you please review the content and provide an /lgtm (or feedback on changes)? I'll need both an SME and QE /lgtm in order to merge content. Thank you!

kdrake20 avatar Sep 30 '24 17:09 kdrake20

Who: @racedo, SME @sgoveas, QE

Summary: Hello! Could I please get an SME and QE review of this content? Please provide feedback directly in the PR. Comment /lgtm if no changes are required. Thank you! Also requested feedback via #forum-ocp-metal-platform

Jira https://github.com/openshift/openshift-docs/pull/77264 Preview

Next Steps:

  • [x] Receive SME approval
  • [x] Receive QE approval

kdrake20 avatar Oct 01 '24 17:10 kdrake20

/lgtm

Thank you @kdrake20

sgoveas avatar Oct 01 '24 20:10 sgoveas

@kdrake20: This pull request references HCIDOCS-188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-188

For: OCP 4.13+

Preview

Approvals - /lgtm:

  • [ ] SME
  • [ ] QE
  • [ ] Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 02 '24 13:10 openshift-ci-robot

@kdrake20: This pull request references HCIDOCS-188 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-188

For: OCP 4.13+

Preview

Approvals - /lgtm:

  • [ ] SME
  • [x] QE
  • [ ] Peer Review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 02 '24 13:10 openshift-ci-robot

/lgtm

elfosardo avatar Oct 02 '24 13:10 elfosardo