openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-19976: Update NFD operator installation to add label cluster-monitoring=true

Open GroceryBoyJr opened this issue 1 year ago • 8 comments

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-19976

Link to docs preview: https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html

QE review:

  • [ ] QE has approved this change.

Additional information:

GroceryBoyJr avatar May 09 '24 18:05 GroceryBoyJr

@GroceryBoyJr: This pull request references Jira Issue OCPBUGS-19976, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…monitoring=true

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-19976

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 18:05 openshift-ci-robot

/assign @liqcui Liquan Cui your QE LGTM desired, please.

GroceryBoyJr avatar May 09 '24 18:05 GroceryBoyJr

🤖 Tue Aug 06 13:25:06 - Prow CI generated the docs preview:

https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html

ocpdocs-previewbot avatar May 09 '24 18:05 ocpdocs-previewbot

/cc @wabouhamad

liqcui avatar May 10 '24 01:05 liqcui

@GroceryBoyJr NFD has been transfer to eco-system, I have assign to @wabouhamad to review the PR. Walid please help to review the pr, thanks!

liqcui avatar May 10 '24 01:05 liqcui

@GroceryBoyJr NFD has been transfer to eco-system, I have assign to @wabouhamad to review the PR. Walid please help to review the pr, thanks!

Thank you so much for your help on this.

GroceryBoyJr avatar May 10 '24 13:05 GroceryBoyJr

/assign @wabouhamad

GroceryBoyJr avatar May 10 '24 13:05 GroceryBoyJr

@wabouhamad your LGTM desired, please, on this short update to the documentation.

GroceryBoyJr avatar May 15 '24 14:05 GroceryBoyJr

/assign @ggordaniRed your qe-approval requested please!

GroceryBoyJr avatar Jul 31 '24 19:07 GroceryBoyJr

/lgtm

ggordaniRed avatar Aug 04 '24 07:08 ggordaniRed

/label peer-review-needed

GroceryBoyJr avatar Aug 05 '24 16:08 GroceryBoyJr

/remove-label peer-review-needed /label peer-review-in-progress

tmalove avatar Aug 05 '24 16:08 tmalove

/unassign @wabouhamad

GroceryBoyJr avatar Aug 05 '24 17:08 GroceryBoyJr

@GroceryBoyJr: This pull request references Jira Issue OCPBUGS-19976, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-19976

Link to docs preview: https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html

QE review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 05 '24 17:08 openshift-ci-robot

/remove-label peer-review-in-progress /label peer-review-done /lgtm

tmalove avatar Aug 05 '24 17:08 tmalove

/label merge-review-needed

GroceryBoyJr avatar Aug 05 '24 18:08 GroceryBoyJr

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Aug 05 '24 21:08 openshift-ci[bot]

Good feedback from @skopacz1 for merge review. Suggestion implemented, FTW!

GroceryBoyJr avatar Aug 05 '24 21:08 GroceryBoyJr

/label merge-review-needed

GroceryBoyJr avatar Aug 05 '24 21:08 GroceryBoyJr

@skopacz1 I've updated per your feedback and re-submitted for merge. Thank you!

GroceryBoyJr avatar Aug 05 '24 21:08 GroceryBoyJr

@skopacz1 thank you, done....hit me!

GroceryBoyJr avatar Aug 06 '24 13:08 GroceryBoyJr

@GroceryBoyJr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 06 '24 13:08 openshift-ci[bot]

/cherrypick enterprise-4.12

skopacz1 avatar Aug 06 '24 13:08 skopacz1

/cherrypick enterprise-4.13

skopacz1 avatar Aug 06 '24 13:08 skopacz1

@GroceryBoyJr: Jira Issue OCPBUGS-19976: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19976 has been moved to the MODIFIED state.

In response to this:

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-19976

Link to docs preview: https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html

QE review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 06 '24 13:08 openshift-ci-robot

/cherrypick enterprise-4.14

skopacz1 avatar Aug 06 '24 13:08 skopacz1

/cherrypick enterprise-4.15

skopacz1 avatar Aug 06 '24 13:08 skopacz1

/cherrypick enterprise-4.16

skopacz1 avatar Aug 06 '24 13:08 skopacz1

/cherrypick enterprise-4.17

skopacz1 avatar Aug 06 '24 13:08 skopacz1

@skopacz1: new pull request created: #80054

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.