OCPBUGS-19976: Update NFD operator installation to add label cluster-monitoring=true
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-19976
Link to docs preview: https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html
QE review:
- [ ] QE has approved this change.
Additional information:
@GroceryBoyJr: This pull request references Jira Issue OCPBUGS-19976, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
…monitoring=true
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-19976
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/assign @liqcui Liquan Cui your QE LGTM desired, please.
🤖 Tue Aug 06 13:25:06 - Prow CI generated the docs preview:
https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html
/cc @wabouhamad
@GroceryBoyJr NFD has been transfer to eco-system, I have assign to @wabouhamad to review the PR. Walid please help to review the pr, thanks!
@GroceryBoyJr NFD has been transfer to eco-system, I have assign to @wabouhamad to review the PR. Walid please help to review the pr, thanks!
Thank you so much for your help on this.
/assign @wabouhamad
@wabouhamad your LGTM desired, please, on this short update to the documentation.
/assign @ggordaniRed your qe-approval requested please!
/lgtm
/label peer-review-needed
/remove-label peer-review-needed /label peer-review-in-progress
/unassign @wabouhamad
@GroceryBoyJr: This pull request references Jira Issue OCPBUGS-19976, which is invalid:
- expected the bug to target the "4.17.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-19976
Link to docs preview: https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html
QE review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/remove-label peer-review-in-progress /label peer-review-done /lgtm
/label merge-review-needed
New changes are detected. LGTM label has been removed.
Good feedback from @skopacz1 for merge review. Suggestion implemented, FTW!
/label merge-review-needed
@skopacz1 I've updated per your feedback and re-submitted for merge. Thank you!
@skopacz1 thank you, done....hit me!
@GroceryBoyJr: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/cherrypick enterprise-4.12
/cherrypick enterprise-4.13
@GroceryBoyJr: Jira Issue OCPBUGS-19976: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-19976 has been moved to the MODIFIED state.
In response to this:
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-19976
Link to docs preview: https://75737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/psap-node-feature-discovery-operator.html
QE review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/cherrypick enterprise-4.14
/cherrypick enterprise-4.15
/cherrypick enterprise-4.16
/cherrypick enterprise-4.17
@skopacz1: new pull request created: #80054
In response to this:
/cherrypick enterprise-4.12
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.