openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS-9969: netobserv cli

Open skrthomas opened this issue 1 year ago • 10 comments

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

skrthomas avatar Apr 23 '24 20:04 skrthomas

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 23 '24 20:04 openshift-ci-robot

🤖 Wed Jun 12 17:35:34 - Prow CI generated the docs preview:

https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install.html https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference.html https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

ocpdocs-previewbot avatar Apr 23 '24 20:04 ocpdocs-previewbot

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 26 '24 20:04 openshift-ci-robot

@jpinsonneau @msherif1234 can you PTAL at this first draft of CLI documentation?

skrthomas avatar Apr 29 '24 18:04 skrthomas

@jpinsonneau & @skrthomas we didn't mention at all here that flows are also stored in sqlite3 DB to ease doing query and enable opensource tools to do basic filtering like Dbeaver as shown in README.md ?

msherif1234 avatar May 06 '24 11:05 msherif1234

@jpinsonneau & @skrthomas we didn't mention at all here that flows are also stored in sqlite3 DB to ease doing query and enable opensource tools to do basic filtering like Dbeaver as shown in README.md ?

that's something we should think about indeed but I'm not sure about mentionning dbeaver or any tool specificly. Let's talk about it in tomorow's doc call

jpinsonneau avatar May 06 '24 12:05 jpinsonneau

@jpinsonneau @msherif1234 I thought those areas of the readme were the same as specifying oc netobserv flows or oc netobserv packets but I see now they may not be. We can discuss more tomorrow in the docs call how we should have these use cases presented in the doc. I need to clarify what is the difference in use case between running oc netobserv flows.... and the Flow capture

skrthomas avatar May 06 '24 20:05 skrthomas

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 09 '24 20:05 openshift-ci-robot

@jpinsonneau @msherif1234 I thought those areas of the readme were the same as specifying oc netobserv flows or oc netobserv packets but I see now they may not be. We can discuss more tomorrow in the docs call how we should have these use cases presented in the doc. I need to clarify what is the difference in use case between running oc netobserv flows.... and the Flow capture

yes @skrthomas flows and packets options are different at moment ideally if we didn't have them and packet capture can show as just another feature to enable and it has its own config options like pcap_protocol and pcap_port ? probably something we can address in the following release WDYT ?

msherif1234 avatar May 09 '24 20:05 msherif1234

@Amoghrd can you PTAL at this PR from QE side?

skrthomas avatar May 13 '24 17:05 skrthomas

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Network Observability CLI overview: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-overview

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 13 '24 18:05 openshift-ci-robot

/label qe-approved

Amoghrd avatar May 21 '24 13:05 Amoghrd

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Network Observability CLI overview: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-overview

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 21 '24 13:05 openshift-ci-robot

/label peer-review-in-progress

bergerhoffer avatar May 21 '24 15:05 bergerhoffer

/label peer-review-done /remove-label peer-review-needed /remove-label peer-review-in-progress

bergerhoffer avatar May 21 '24 18:05 bergerhoffer

@jpinsonneau I'm experiencing Prow issues across all my PRs unfortunately. I have people on it to help me figure out what is going on, but in the meantime, I'm wondering if you can PTAL at this again and let me know if all the changes look OK to you? I know we're still waiting for the tar file link, and I'm unsure if the installation steps I have are still OK?

skrthomas avatar Jun 04 '24 02:06 skrthomas

/retest

aireilly avatar Jun 04 '24 08:06 aireilly

Closing and waiting 15 min before reopening to kick Prow

aireilly avatar Jun 04 '24 09:06 aireilly

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Network Observability CLI overview: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-overview

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 04 '24 10:06 openshift-ci-robot

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Merge only to no-1.6.

Do not merge but asking for merge review now so I may address any feedback now and merge next week once I'm certain of the tar link in the Installation. Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Network Observability CLI overview: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-overview

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 06 '24 20:06 openshift-ci-robot

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Merge only to no-1.6.

Do not merge but asking for merge review now so I may address any feedback now and merge next week once I'm certain of the tar link in the Installation. Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Network Observability CLI overview: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-overview

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install.html

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 07 '24 14:06 openshift-ci-robot

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Merge only to no-1.6.

Do not merge but asking for merge review now so I may address any feedback now and merge next week once I'm certain of the tar link in the Installation. Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install.html

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 07 '24 14:06 openshift-ci-robot

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Merge only to no-1.6.

Do not merge but asking for merge review now so I may address any feedback now and merge next week once I'm certain of the tar link in the Installation. Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install.html

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [X] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 11 '24 13:06 openshift-ci-robot

Looks good to me ! Thanks @skrthomas

jpinsonneau avatar Jun 12 '24 14:06 jpinsonneau

@skrthomas: This pull request references OSDOCS-9969 which is a valid jira issue.

In response to this:

Version(s):

Merge only to no-1.6.

Issue:

https://issues.redhat.com/browse/OSDOCS-9969 Link to docs preview:

Installing netobserv CLI: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-install.html

Using CLI commands: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-using.html

CLI reference: https://75055--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/netobserv_cli/netobserv-cli-reference

QE review:

  • [X] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 12 '24 14:06 openshift-ci-robot

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 12 '24 17:06 openshift-ci[bot]