openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OBSDOCS-695:Update Network Observability doc links and topic map posi…

Open skrthomas opened this issue 1 year ago • 7 comments

…tion

Version(s):

Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

https://73554--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes QE review:

  • [ ] QE has approved this change.

Additional information:

skrthomas avatar Mar 21 '24 15:03 skrthomas

@skrthomas: This pull request references OBSDOCS-695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

…tion

Version(s):

Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 21 '24 15:03 openshift-ci-robot

🤖 Fri Mar 29 14:09:34 - Prow CI generated the docs preview: https://73554--ocpdocs-pr.netlify.app

ocpdocs-previewbot avatar Mar 21 '24 15:03 ocpdocs-previewbot

/retest

skrthomas avatar Mar 22 '24 14:03 skrthomas

@skrthomas: This pull request references OBSDOCS-695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

…tion

Version(s):

Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

https://73554--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 22 '24 14:03 openshift-ci-robot

/retest

skrthomas avatar Mar 22 '24 18:03 skrthomas

@skrthomas: This pull request references OBSDOCS-695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.12+ Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

https://73554--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 26 '24 16:03 openshift-ci-robot

@skrthomas: This pull request references OBSDOCS-695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.12+ Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

https://73554--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes QE review:

  • QE review not required. This change is part of a broad effort to reorganize Observability documentation under an Observability category. This change has been approved by different levels of PM. See, https://github.com/openshift/openshift-docs/pull/71248 and image

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 26 '24 17:03 openshift-ci-robot

@skrthomas: This pull request references OBSDOCS-695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.12+ Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

https://73554--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes QE review:

  • QE review not required. This change is part of a broad effort to reorganize Observability documentation under an Observability category. This change has been approved by different levels of PM. See related PR, https://github.com/openshift/openshift-docs/pull/71248 and image

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 26 '24 17:03 openshift-ci-robot

@skrthomas: This pull request references OBSDOCS-695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.12+ Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

https://73554--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes QE review:

  • QE review not required. This change is part of a broad effort to reorganize Observability documentation under an Observability category. This change has been approved by different levels of PM. See related PR, https://github.com/openshift/openshift-docs/pull/71248 and image

Additional information:

This PR changes the topic map file, turns the assembly directories for network_observability subdirectories of observability, and updates the affected xrefs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 26 '24 17:03 openshift-ci-robot

@skrthomas: This pull request references OBSDOCS-695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.12+ Issue:

https://issues.redhat.com/browse/OBSDOCS-695 Link to docs preview:

https://73554--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/network-observability-operator-release-notes QE review:

  • QE review not required. This change is part of a broad effort to reorganize Observability documentation under an Observability category. This change has been approved by different levels of PM. See related PR, https://github.com/openshift/openshift-docs/pull/71248 and image

Additional information:

This PR changes the topic map file, turns the assembly directory for network_observability into a subdirectory of observability, and updates the affected xrefs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 26 '24 17:03 openshift-ci-robot

/label peer-review-in-progress /remove-label peer-review-needed

mramendi avatar Mar 26 '24 20:03 mramendi

As I am in peer review induction, @JoeAldinger will finish this review

mramendi avatar Mar 26 '24 21:03 mramendi

cc @kalexand-rh not sure what is going on here and why the build is passing.

JoeAldinger avatar Mar 27 '24 14:03 JoeAldinger

Thanks @mramendi. I changed the links in networking/networking-dashboards.adoc and networking/networking-operators-overview.adoc to have a link path: xref:../observability/network_observability. However, in all of my other assembly files, I tried to do xref:../observability/network_observability or ../../observability/network_observability, but I kept getting build errors. When I talked to Joe, he suggested doing ../../network_observability. It didn't break the PR he pulled down, so hopefully I'm going to try that on this PR and see.

skrthomas avatar Mar 27 '24 19:03 skrthomas

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 29 '24 14:03 openshift-ci[bot]

/cherrypick enterprise-4.16

kelbrown20 avatar Mar 29 '24 14:03 kelbrown20

/cherrypick enterprise-4.15

kelbrown20 avatar Mar 29 '24 14:03 kelbrown20

/cherrypick enterprise-4.14

kelbrown20 avatar Mar 29 '24 14:03 kelbrown20

/cherrypick enterprise-4.13

kelbrown20 avatar Mar 29 '24 14:03 kelbrown20

/cherrypick enterprise-4.12

kelbrown20 avatar Mar 29 '24 14:03 kelbrown20

@kelbrown20: new pull request created: #73947

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20: new pull request created: #73948

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20: #73554 failed to apply on top of branch "enterprise-4.14":

Applying: OBSDOCS-695:Update Network Observability doc links and topic map position
.git/rebase-apply/patch:304: trailing whitespace.
* xref:../../observability/network_observability/flowcollector-api.adoc#network-observability-flowcollector-api-specifications_network_observability[Flow Collector API Reference] 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
A	networking/networking-dashboards.adoc
M	welcome/index.adoc
Falling back to patching base and 3-way merge...
Auto-merging welcome/index.adoc
CONFLICT (content): Merge conflict in welcome/index.adoc
CONFLICT (content): Merge conflict in observability/network_observability/snippets
CONFLICT (content): Merge conflict in observability/network_observability/modules
CONFLICT (content): Merge conflict in observability/network_observability/images
CONFLICT (content): Merge conflict in observability/network_observability/_attributes
CONFLICT (modify/delete): networking/networking-dashboards.adoc deleted in HEAD and modified in OBSDOCS-695:Update Network Observability doc links and topic map position. Version OBSDOCS-695:Update Network Observability doc links and topic map position of networking/networking-dashboards.adoc left in tree.
Removing network_observability/installing-operators.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OBSDOCS-695:Update Network Observability doc links and topic map position
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20: #73554 failed to apply on top of branch "enterprise-4.13":

Applying: OBSDOCS-695:Update Network Observability doc links and topic map position
.git/rebase-apply/patch:304: trailing whitespace.
* xref:../../observability/network_observability/flowcollector-api.adoc#network-observability-flowcollector-api-specifications_network_observability[Flow Collector API Reference] 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	network_observability/network-observability-operator-release-notes.adoc
A	networking/networking-dashboards.adoc
M	observability/index.adoc
M	welcome/index.adoc
Falling back to patching base and 3-way merge...
Auto-merging welcome/index.adoc
CONFLICT (content): Merge conflict in welcome/index.adoc
CONFLICT (content): Merge conflict in observability/network_observability/snippets
Auto-merging observability/network_observability/network-observability-operator-release-notes.adoc
CONFLICT (content): Merge conflict in observability/network_observability/network-observability-operator-release-notes.adoc
CONFLICT (content): Merge conflict in observability/network_observability/modules
CONFLICT (content): Merge conflict in observability/network_observability/images
CONFLICT (content): Merge conflict in observability/network_observability/_attributes
Auto-merging observability/index.adoc
CONFLICT (modify/delete): networking/networking-dashboards.adoc deleted in HEAD and modified in OBSDOCS-695:Update Network Observability doc links and topic map position. Version OBSDOCS-695:Update Network Observability doc links and topic map position of networking/networking-dashboards.adoc left in tree.
Removing network_observability/installing-operators.adoc
Auto-merging _topic_maps/_topic_map.yml
CONFLICT (content): Merge conflict in _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OBSDOCS-695:Update Network Observability doc links and topic map position
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20: #73554 failed to apply on top of branch "enterprise-4.12":

Applying: OBSDOCS-695:Update Network Observability doc links and topic map position
.git/rebase-apply/patch:304: trailing whitespace.
* xref:../../observability/network_observability/flowcollector-api.adoc#network-observability-flowcollector-api-specifications_network_observability[Flow Collector API Reference] 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	network_observability/installing-operators.adoc
M	network_observability/network-observability-operator-release-notes.adoc
M	network_observability/observing-network-traffic.adoc
A	networking/networking-dashboards.adoc
M	observability/index.adoc
M	welcome/index.adoc
Falling back to patching base and 3-way merge...
Auto-merging welcome/index.adoc
CONFLICT (content): Merge conflict in welcome/index.adoc
CONFLICT (content): Merge conflict in observability/network_observability/snippets
Auto-merging observability/network_observability/observing-network-traffic.adoc
CONFLICT (content): Merge conflict in observability/network_observability/observing-network-traffic.adoc
Auto-merging observability/network_observability/network-observability-operator-release-notes.adoc
CONFLICT (content): Merge conflict in observability/network_observability/network-observability-operator-release-notes.adoc
CONFLICT (content): Merge conflict in observability/network_observability/modules
CONFLICT (content): Merge conflict in observability/network_observability/images
CONFLICT (content): Merge conflict in observability/network_observability/_attributes
Auto-merging observability/index.adoc
CONFLICT (modify/delete): networking/networking-dashboards.adoc deleted in HEAD and modified in OBSDOCS-695:Update Network Observability doc links and topic map position. Version OBSDOCS-695:Update Network Observability doc links and topic map position of networking/networking-dashboards.adoc left in tree.
CONFLICT (modify/delete): network_observability/installing-operators.adoc deleted in OBSDOCS-695:Update Network Observability doc links and topic map position and modified in HEAD. Version HEAD of network_observability/installing-operators.adoc left in tree.
Auto-merging _topic_maps/_topic_map.yml
CONFLICT (content): Merge conflict in _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OBSDOCS-695:Update Network Observability doc links and topic map position
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.