openshift
OSDOCS-8651: Edits from content audit
Version(s): 4.15+
Issue: https://issues.redhat.com/browse/OSDOCS-8651
Link to docs preview: https://73505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/dns-operator
QE review:
- [ ] QE has approved this change.
@ahardin-rh: This pull request references OSDOCS-8651 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: (https://issues.redhat.com/browse/OSDOCS-8651
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Wed Mar 27 15:01:01 - Prow CI generated the docs preview: https://73505--ocpdocs-pr.netlify.app
@ahardin-rh: This pull request references OSDOCS-8651 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: (https://issues.redhat.com/browse/OSDOCS-8651
Link to docs preview: https://73505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/dns-operator
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@candita Thank you again for your awesome feedback. I implemented the updates as you noted. Can you please scan these changes to see if I missed anything?
@melvinjoseph86 Can you please provide QE ack? These edits are for clarity and an improved customer experience. Thank you!
@ahardin-rh: This pull request references OSDOCS-8651 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: https://issues.redhat.com/browse/OSDOCS-8651
Link to docs preview: https://73505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/dns-operator
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@kcarmichael08 Thank you for the excellent review feedback! :rocket: Updated. Just waiting for guidance on reworking the jq commands, if possible.
@ahardin-rh: This pull request references OSDOCS-8651 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: https://issues.redhat.com/browse/OSDOCS-8651
Link to docs preview: https://73505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/dns-operator
QE review:
- [ ] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@ahardin-rh: This pull request references OSDOCS-8651 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s): 4.15+
Issue: https://issues.redhat.com/browse/OSDOCS-8651
Link to docs preview: https://73505--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/dns-operator
QE review:
- [x] QE has approved this change.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@ahardin-rh: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ahardin-rh: #73505 failed to apply on top of branch "enterprise-4.15":
Applying: OSDOCS-8651: Edits from content audit
.git/rebase-apply/patch:538: trailing whitespace.
$ oc get dns.operator.openshift.io default -ojsonpath='{.spec.managementState}'
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M modules/nw-dns-view.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-dns-view.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-view.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-8651: Edits from content audit
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@ahardin-rh: #73505 failed to apply on top of branch "enterprise-4.16":
Applying: OSDOCS-8651: Edits from content audit
.git/rebase-apply/patch:538: trailing whitespace.
$ oc get dns.operator.openshift.io default -ojsonpath='{.spec.managementState}'
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M modules/nw-dns-view.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-dns-view.adoc
CONFLICT (content): Merge conflict in modules/nw-dns-view.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-8651: Edits from content audit
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.