openshift
OADP-3716: seg fault in openshift-adp-controller-manager
JIRA
VERSIONS
- OCP 4.12 → branch/enterprise-4.12
- OCP 4.13 → branch/enterprise-4.13
- OCP 4.14 → branch/enterprise-4.14
- OCP 4.15 → branch/enterprise-4.15
- OCP 4.16 → branch/enterprise-4.16
Link to docs preview:
QE review:
- [X ] QE has approved this change. LGTM
Additional information:
@anarnold97: This pull request references OADP-3716 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@anarnold97: This pull request references OADP-3716 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
VERSIONS
- OCP 4.12 → branch/enterprise-4.12
- OCP 4.13 → branch/enterprise-4.13
- OCP 4.14 → branch/enterprise-4.14
- OCP 4.15 → branch/enterprise-4.15
- OCP 4.16 → branch/enterprise-4.16
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Mon Mar 25 21:12:13 - Prow CI generated the docs preview: https://73315--ocpdocs-pr.netlify.app
@anarnold97: This pull request references OADP-3716 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
VERSIONS
- OCP 4.12 → branch/enterprise-4.12
- OCP 4.13 → branch/enterprise-4.13
- OCP 4.14 → branch/enterprise-4.14
- OCP 4.15 → branch/enterprise-4.15
- OCP 4.16 → branch/enterprise-4.16
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@anarnold97: This pull request references OADP-3716 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
JIRA
VERSIONS
- OCP 4.12 → branch/enterprise-4.12
- OCP 4.13 → branch/enterprise-4.13
- OCP 4.14 → branch/enterprise-4.14
- OCP 4.15 → branch/enterprise-4.15
- OCP 4.16 → branch/enterprise-4.16
Link to docs preview:
QE review:
- [X ] QE has approved this change. LGTM
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hi @anarnold97, when I looked up Wes, he didn't appear to be a QE associate, so that wouldn't count. It has to be someone from the QE organization. I'm not familiar with the OADP but I'm assuming that the QA contact from the jira (@stillalearner) would be the right person to review.
I'm removing the merge-review label for now, you can add it back in once you've gotten QE approval. Thanks!
Hi @anarnold97, when I looked up Wes, he didn't appear to be a QE associate, so that wouldn't count. It has to be someone from the QE organization. I'm not familiar with the OADP but I'm assuming that the QA contact from the jira (@stillalearner) would be the right person to review.
I'm removing the merge-review label for now, you can add it back in once you've gotten QE approval. Thanks!
You said "but that's what we need SME/QE approval to be sure of." Wes qualifies as an SME as lead dev on OADP.
The approval comes from the lead dev on OADP. Therefore qualifies as an SME.
@anarnold97: The label(s) `/label merge-review-neeed
cannot be applied. These labels are supported:acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?
In response to this:
/label merge-review-neeed
The approval comes from the lead dev on OADP. Therefore qualifies as an SME.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@anarnold97: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@anarnold97 SME doesn't count, it must be from a QE associate.
Please see our guidelines here on QE required before merging: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#verification-of-your-content
All documentation changes that update or add technical content must be verified by a QE team associate before merging.
And also the piece of the pull request template that states (in comments):
QE approval is required to merge a PR except for changes that do not impact the meaning of the docs.
Please obtain QE approval before requesting a merge again. Let us know if you need help with requesting QE approval.
@bergerhoffer this was an urgent ticket for a customer Yesterday was a holiday in India, and you have delayed this. Wes is clearly more than qualified to know what changes in OADP are applicable. I will delay this further by asking Sachin for a review
But I do not want you involved in any reviews for OADP documentation any more.
@anarnold97, all content additions require QE review, and Andrea's correct that this change does need QE. I think that any of the peer or merge reviewers would have either called out the lack of QE or review or tagged me in about it, so just asking Andrea to step back from OADP reviews won't "help."
