openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

RHDEVDOCS-4410 - Doc: Resource type updates-Import from Git & deploy image

Open smunje1 opened this issue 3 years ago • 2 comments

RHDEVDOCS-4410: Doc: Resource type updates-Import from Git & deploy image

Aligned team: Dev Tools OCP version for cherry-picking: enterprise-4.12 JIRA issues: RHDEVDOCS-4410 Preview pages: Download to see the preview in your browser SME Review: @divyanshiGupta QE review: @sanketpathak Peer-review:

smunje1 avatar Oct 17 '22 08:10 smunje1

🤖 Updated build preview is available at: https://51733--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3017

ocpdocs-previewbot avatar Oct 17 '22 08:10 ocpdocs-previewbot

Hello @divyanshiGupta Could you help with the SME review for this PR?

Thank you!

smunje1 avatar Oct 17 '22 08:10 smunje1

Hello @divyanshiGupta. I have incorporated your feedback. Could you please have a look and confirm?

Thank you!

smunje1 avatar Oct 19 '22 11:10 smunje1

LGTM.

divyanshiGupta avatar Oct 21 '22 04:10 divyanshiGupta

Hello @sanketpathak Could you help with the QE review for this PR?

Thank you!

smunje1 avatar Oct 21 '22 04:10 smunje1

Hello @sanketpathak Could you help me understand if you got a chance to look into this PR?

Thank you!

smunje1 avatar Oct 31 '22 06:10 smunje1

LGTM

sanketpathak avatar Nov 03 '22 09:11 sanketpathak

@sounix000 Thanks for your suggestion. I have incorporated your feedback. Please confirm and send your approval.

After the updates, a screenshot: image

smunje1 avatar Nov 04 '22 10:11 smunje1

LGTM

sounix000 avatar Nov 04 '22 10:11 sounix000

After the updates, a screenshot: image

@bburt-rh Thanks for your suggestion. Very good catch. Could you please take a look now?

Thank you!

smunje1 avatar Nov 04 '22 13:11 smunje1

/cherrypick enterprise-4.12

bburt-rh avatar Nov 04 '22 13:11 bburt-rh

@bburt-rh: new pull request created: #52497

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.