openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

Update configuring-firewall.adoc

Open Rupesh-git-eng opened this issue 3 years ago • 3 comments

The domain cdn03.quay.io doesn't exist in dns, if so, we should remove it. I tried a couple of DNS servers from different geo's.

Version(s): Openshift 4.7 onwards.

Issue: We have a domain name link that doesn't really exist.

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Rupesh-git-eng avatar Oct 14 '22 09:10 Rupesh-git-eng

🤖 Build preview is available at: https://51687--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/1821

ocpdocs-previewbot avatar Oct 14 '22 10:10 ocpdocs-previewbot

@gpei, will you PTAL or suggest another reviewer?

kalexand-rh avatar Oct 17 '22 15:10 kalexand-rh

LGTM, thanks for the update.

gpei avatar Oct 18 '22 01:10 gpei

/cherrypick enterprise-4.7

kalexand-rh avatar Oct 19 '22 14:10 kalexand-rh

/cherrypick enterprise-4.8

kalexand-rh avatar Oct 19 '22 14:10 kalexand-rh

/cherrypick enterprise-4.9

kalexand-rh avatar Oct 19 '22 14:10 kalexand-rh

/cherrypick enterprise-4.10

kalexand-rh avatar Oct 19 '22 14:10 kalexand-rh

/cherrypick enterprise-4.11

kalexand-rh avatar Oct 19 '22 14:10 kalexand-rh

/cherrypick enterprise-4.12

kalexand-rh avatar Oct 19 '22 14:10 kalexand-rh

@kalexand-rh: #51687 failed to apply on top of branch "enterprise-4.7":

Applying: Update configuring-firewall.adoc
Using index info to reconstruct a base tree...
M	modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update configuring-firewall.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh: #51687 failed to apply on top of branch "enterprise-4.9":

Applying: Update configuring-firewall.adoc
Using index info to reconstruct a base tree...
M	modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update configuring-firewall.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh: #51687 failed to apply on top of branch "enterprise-4.10":

Applying: Update configuring-firewall.adoc
Using index info to reconstruct a base tree...
M	modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update configuring-firewall.adoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh: new pull request created: #51840

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh: new pull request created: #51841

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rupesh-git-eng, the note is different in version 4.10 and earlier. Please confirm that this entire change is valid in 4.7 - 4.10.

kalexand-rh avatar Oct 19 '22 14:10 kalexand-rh

@Rupesh-git-eng, the note is different in version 4.10 and earlier. Please confirm that this entire change is valid in 4.7 - 4.10.

@kalexand-rh in both cases, I believe it still applies as the specific record 'cdn03.quay.io' doesn't exist. Both versions have the same sub domain that is not configured yet.

Rupesh-git-eng avatar Oct 19 '22 14:10 Rupesh-git-eng

@kalexand-rh If this still needs to be CPd to 4.8+, can you please look into it when you get a chance?

bergerhoffer avatar Nov 15 '22 17:11 bergerhoffer