openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

Telcodocs 780 410 revert changes to pre 47172

Open kquinn1204 opened this issue 3 years ago • 3 comments

TELCODOCS-780: Reverting changes made in PR 47172 Changes made in PR https://github.com/openshift/openshift-docs/pull/47172 have not made it through to 4.10.z stream release.

Version(s): PR applies to 4.10 only

Issue: https://issues.redhat.com/browse/TELCODOCS-780

Link to docs preview: http://file.emea.redhat.com/kquinn/TELCODOCS-780-410-revert/networking/hardware_networks/using-pod-level-bonding.html

Item 1. Adding back in the TP notice Item 2. Adding back in the note about BZ#2037214

kquinn1204 avatar Aug 17 '22 14:08 kquinn1204

@mmirecki @evgenLevin @cgoncalves I am reverting the change I mistakenly pushed through in PR https://github.com/openshift/openshift-docs/pull/47172. Content should be same as the original 4.10 content prior to the change. Can you give this a LGTM.

kquinn1204 avatar Aug 17 '22 14:08 kquinn1204

Can we get this merged without Change Management, please? CM wasn't done in #47172, so the correct state is actually when this PR is merged.

We will do CM when re-introducing the content at the time of its intended release.

tradej avatar Aug 17 '22 14:08 tradej

LGTM

cgoncalves avatar Aug 17 '22 15:08 cgoncalves

LGTM

evgenLevin avatar Aug 18 '22 10:08 evgenLevin

@mjpytlak We are literally just reverting a previous commit, let's leave any further changes to a separate PR, please.

tradej avatar Aug 18 '22 12:08 tradej

HI @tradej @mjpytlak I compared the content in this submit with the original 4.10 content pre the erroneous commit and they are the same. As @tradej says there is no requirement to action the review comment as this is simply a revert and I want to revert it to how it was originally. Hopefully this can be merged

kquinn1204 avatar Aug 18 '22 14:08 kquinn1204

Thanks both. @kquinn1204, can you make a separate PR for the changes @mjpytlak requested, please?

tradej avatar Aug 18 '22 14:08 tradej

Yes will do all

kquinn1204 avatar Aug 18 '22 15:08 kquinn1204