Add csi node user-facing configuration
@copejon - could we reorganize the commits into at most 3?
Just not to forget, please,clean up and squash the commits if possible to avoid having 25 commits in history.
/kind feature
/retest
I'm happy with this version. I'd like to give @fzdarsky a chance to comment on the configuration layout and whether we want to put the storage-related settings in a subsection.
/lgtm /hold
I have two questions:
- Some files under controllers/, pkg/mdns and pkg/util contain tabulation changes in the license text. Do we want these in the current PR?
- Do we need to have user documentation updated to reflect this new functionality?
I have two questions:
* Some files under controllers/, pkg/mdns and pkg/util contain tabulation changes in the license text. Do we want these in the current PR?
It seems that it won't pass the verify check otherwise. Not sure why this is being caught now though.
* Do we need to have user documentation updated to reflect this new functionality?
I'll circle back and make sure the in-repo docs are accurate.
/retest
/retest
/retest
/retest
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: copejon, dhellmann
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [copejon,dhellmann]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@copejon: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.