microshift icon indicating copy to clipboard operation
microshift copied to clipboard

Add csi node user-facing configuration

Open copejon opened this issue 3 years ago • 8 comments

Which issue(s) this PR addresses:

Closes USHIFT-168

copejon avatar Aug 24 '22 23:08 copejon

@copejon - could we reorganize the commits into at most 3?

ggiguash avatar Aug 25 '22 11:08 ggiguash

Just not to forget, please,clean up and squash the commits if possible to avoid having 25 commits in history.

oglok avatar Aug 25 '22 14:08 oglok

/kind feature

dhellmann avatar Aug 26 '22 21:08 dhellmann

/retest

ggiguash avatar Aug 28 '22 05:08 ggiguash

I'm happy with this version. I'd like to give @fzdarsky a chance to comment on the configuration layout and whether we want to put the storage-related settings in a subsection.

/lgtm /hold

dhellmann avatar Aug 31 '22 21:08 dhellmann

I have two questions:

  • Some files under controllers/, pkg/mdns and pkg/util contain tabulation changes in the license text. Do we want these in the current PR?
  • Do we need to have user documentation updated to reflect this new functionality?

ggiguash avatar Sep 30 '22 05:09 ggiguash

I have two questions:

* Some files under controllers/, pkg/mdns and pkg/util contain tabulation changes in the license text. Do we want these in the current PR?

It seems that it won't pass the verify check otherwise. Not sure why this is being caught now though.

* Do we need to have user documentation updated to reflect this new functionality?

I'll circle back and make sure the in-repo docs are accurate.

copejon avatar Oct 03 '22 22:10 copejon

/retest

copejon avatar Oct 06 '22 21:10 copejon

/retest

copejon avatar Oct 07 '22 01:10 copejon

/retest

copejon avatar Oct 07 '22 01:10 copejon

/retest

copejon avatar Oct 07 '22 14:10 copejon

/hold cancel

dhellmann avatar Oct 07 '22 19:10 dhellmann

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [copejon,dhellmann]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 07 '22 21:10 openshift-ci[bot]

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 07 '22 21:10 openshift-ci[bot]