microshift icon indicating copy to clipboard operation
microshift copied to clipboard

USHIFT-227: Cluster Policy Controller integration

Open oglok opened this issue 3 years ago • 19 comments

Which issue(s) this PR addresses:

Closes USHIFT-227

This PR carry the following items:

  • Enabling Cluster Policy Controller
  • Disabling resource-quota and cluster-quota-reconciliation controllers.
  • Creating of openshift-kube-controller-manager namespace (it's where the CreatedSCCRanges events happen)
  • Applying csr-approver and namespace-security cluster roles and cluster role bindings. (required by the CPC)

oglok avatar Jul 29 '22 16:07 oglok

I'll test it more intensively on Monday

oglok avatar Jul 29 '22 16:07 oglok

/retest

oglok avatar Aug 04 '22 11:08 oglok

@oglok would you also please update the PR description with all the necessary steps that were carried? It will be easier to follow the changes and why their were needed.

ingvagabund avatar Aug 05 '22 11:08 ingvagabund

Sure, I'll update the PR description.

oglok avatar Aug 05 '22 11:08 oglok

mmit are in most cases obsolete in the following one. Would it be possible to clean the commits first? Making sure only the

PR's commits are squashed and rebased.

oglok avatar Aug 05 '22 16:08 oglok

/lgtm

benluddy avatar Aug 05 '22 17:08 benluddy

/retest-required

Remaining retests: 2 against base HEAD 65c74b01120297105030a83e41fc0574d3fc9062 and 8 for PR HEAD 0c858649ec324d15530598b443ef3f67eae7a7cc in total

openshift-ci-robot avatar Aug 05 '22 18:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD 65c74b01120297105030a83e41fc0574d3fc9062 and 7 for PR HEAD 0c858649ec324d15530598b443ef3f67eae7a7cc in total

openshift-ci-robot avatar Aug 05 '22 18:08 openshift-ci-robot

/retest-required

benluddy avatar Aug 05 '22 20:08 benluddy

/retest

oglok avatar Aug 05 '22 22:08 oglok

/retest

ggiguash avatar Aug 06 '22 05:08 ggiguash

/retest

oglok avatar Aug 06 '22 09:08 oglok

/retest

oglok avatar Aug 08 '22 14:08 oglok

/retest

mangelajo avatar Aug 08 '22 16:08 mangelajo

The e2e-openshift-conformance-sig-storage is failing. Apparently, there is something in the Cluster Policy Controller preventing the CSI registrar container to work. Investigating.

oglok avatar Aug 09 '22 09:08 oglok

There are two parameters in the node object that are not being written due to this PR (for whatever reason).

The following annotation: csi.volume.kubernetes.io/nodeid: '{"topolvm.cybozu.com":"maxwell.ogloknet.com"}'

and the following label:

topology.topolvm.cybozu.com/node: maxwell.ogloknet.com

oglok avatar Aug 09 '22 10:08 oglok

/approve

mangelajo avatar Aug 11 '22 09:08 mangelajo

/retest-required

https://search.ci.openshift.org/?search=resource+Deployment%3Aopenshift-storage%2Ftopolvm-controller&maxAge=336h&context=-1&type=build-log&name=.-microshift-.&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

benluddy avatar Aug 11 '22 17:08 benluddy

/lgtm

benluddy avatar Aug 11 '22 18:08 benluddy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, mangelajo, oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [mangelajo,oglok]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 11 '22 18:08 openshift-ci[bot]

/retest-required

Remaining retests: 2 against base HEAD e6980e25714fa6ae188c76aa52615388372e66a3 and 8 for PR HEAD 3a28b7a0962b10c6fbd147378455f2bc9bda08fd in total

openshift-ci-robot avatar Aug 11 '22 19:08 openshift-ci-robot

@oglok: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 11 '22 20:08 openshift-ci[bot]