managed-cluster-config icon indicating copy to clipboard operation
managed-cluster-config copied to clipboard

SDCICD-1292: set MGO NS resourceApplyMode=Upsert

Open jbpratt opened this issue 1 year ago • 4 comments

What type of PR is this?

/cleanup

What this PR does / why we need it?

This namespace should not be defined in MCC as it conflicts with the namespace defined in the operator repository. Set the resourceApplyMode to Upsert to allow deleting the SSS in a future PR, and avoiding deletion of the namespace itself (the other SSS will take care of that).

The namespace is also defined here:

https://github.com/openshift/must-gather-operator/blob/36981769f414e8c138484e4c8f370cba63aafa1c/hack/olm-registry/olm-artifacts-template.yaml#L33

https://redhat-internal.slack.com/archives/CFJD1NZFT/p1716216917180149?thread_ts=1715864690.782999&cid=CFJD1NZFT

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/SDCICD-1292

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster

  • [ ] Included documentation changes with PR

  • [ ] If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]
    

jbpratt avatar May 22 '24 09:05 jbpratt

@jbpratt: This pull request references SDCICD-1292 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

What type of PR is this?

/cleanup

What this PR does / why we need it?

This namespace should not be defined in MCC as it conflicts with the namespace defined in the operator repository. Set the resourceApplyMode to Upsert to allow deleting the SSS in a future PR, and avoiding deletion of the namespace itself (the other SSS will take care of that).

The namespace is also defined here:

https://github.com/openshift/must-gather-operator/blob/36981769f414e8c138484e4c8f370cba63aafa1c/hack/olm-registry/olm-artifacts-template.yaml#L33

https://redhat-internal.slack.com/archives/CFJD1NZFT/p1716216917180149?thread_ts=1715864690.782999&cid=CFJD1NZFT

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/SDCICD-1292

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster

  • [ ] Included documentation changes with PR

  • [ ] If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]
    

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 09:05 openshift-ci-robot

/assign @mjlshen @AlexVulaj

jbpratt avatar May 22 '24 09:05 jbpratt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 04 '24 18:06 openshift-ci[bot]

@jbpratt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 04 '24 18:06 openshift-ci[bot]