openshift
OU-229: Remove Observe > Targets page code
This page is now provided by the monitoring-plugin dynamic plugin and nothing in the console codebase is using these components.
@kyoto: This pull request references OU-229 which is a valid jira issue.
In response to this:
This page is now provided by the
monitoring-plugindynamic plugin and nothing in the console codebase is using these components.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This is a refactoring change. There should be no user visible changes.
/label docs-approved /label px-approved
Do you think we need to add "Targets" : "Targets" back into frontend/public/locales/en/public.json?
The ci/prow/e2e-gcp-console error mentioned "Failed: Missing i18n key "Targets" in namespace "public" and language "en." exception Error: Failed: Missing i18n key "Targets" in namespace "public" and language "en." "
@zhuje Thanks! I had missed that error message. I think this is the necessary fix: https://github.com/openshift/monitoring-plugin/pull/73
test PR with cluster bot, failed to see Observe page as admin Dynamic plugins shows monitoring-plugin failed
https://github.com/openshift/console/assets/99250368/c627ea67-bdf5-477b-be85-9fdf9756b861
@Tai-RedHat from the screen recording, you used 4.15 payload to test this PR, the master branch is 4.16 now, I am afraid this is the reason that the test did not pass. cc: @kyoto
@Tai-RedHat from the screen recording, you used 4.15 payload to test this PR, the master branch is 4.16 now, I am afraid this is the reason that the test did not pass. cc: @kyoto
yes, it's a payload issue.
test with cluster-bot 4.16 build, Observe pages worked well. /label qe-approved
@kyoto: This pull request references OU-229 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.16." or "openshift-4.16.", but it targets "OpenShift 4.14" instead.
In response to this:
This page is now provided by the
monitoring-plugindynamic plugin and nothing in the console codebase is using these components.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 9d4a9b0a01b2de64b308f8423a325f1fae5f8726 and 2 for PR HEAD 75173d46ffcae2341318757dff1e287324075401 in total