console icon indicating copy to clipboard operation
console copied to clipboard

add tab extension to dev console

Open jgbernalp opened this issue 3 years ago • 5 comments

This PR adds a new extension type to be able to add tabs on the HosrizontalNav component in specific sections

Screenshot 2022-09-28 at 11 33 16

https://issues.redhat.com/browse/OU-49

jgbernalp avatar Sep 28 '22 09:09 jgbernalp

/retest

jgbernalp avatar Sep 28 '22 13:09 jgbernalp

/cc /cc @christianvogt

spadgett avatar Oct 03 '22 13:10 spadgett

/retest-required

jgbernalp avatar Oct 18 '22 14:10 jgbernalp

minor comment but otherwise looks good /approve

christianvogt avatar Oct 20 '22 15:10 christianvogt

/assign @yapei @opayne1 @RickJWagner for approvals

jgbernalp avatar Oct 24 '22 08:10 jgbernalp

/label px-approved

RickJWagner avatar Oct 24 '22 18:10 RickJWagner

/label docs-approved

opayne1 avatar Oct 24 '22 18:10 opayne1

with console.tab extension and all required property defined, user can add tab to any specific page matching with contextId Screen Shot 2022-10-26 at 10 23 08 /label qe-approved

yapei avatar Oct 26 '22 06:10 yapei

/lgtm

christianvogt avatar Oct 27 '22 13:10 christianvogt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 27 '22 13:10 openshift-ci[bot]

/retest-required

jgbernalp avatar Oct 27 '22 14:10 jgbernalp

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 27 '22 18:10 openshift-ci[bot]