console icon indicating copy to clipboard operation
console copied to clipboard

[release-4.10] Bug 2080389: Link to documentation from the overview page goes to a missing link

Open jhadvig opened this issue 3 years ago • 15 comments

manual backport of https://github.com/openshift/console/pull/11668/files

/assign @rhamilto

jhadvig avatar Aug 01 '22 11:08 jhadvig

@jhadvig: This pull request references Bugzilla bug 2080389, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "4.11.z" instead
  • expected dependent Bugzilla bug 2071747 to target a release in 4.11.0, but it targets "4.12.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.10] Bug 2080389: Link to documentation from the overview page goes to a missing link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 01 '22 11:08 openshift-ci[bot]

/bugzilla refresh

jhadvig avatar Aug 01 '22 11:08 jhadvig

@jhadvig: This pull request references Bugzilla bug 2080389, which is invalid:

  • expected dependent Bugzilla bug 2071747 to target a release in 4.11.0, but it targets "4.12.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 01 '22 11:08 openshift-ci[bot]

/bugzilla refresh

jhadvig avatar Aug 01 '22 11:08 jhadvig

@jhadvig: This pull request references Bugzilla bug 2080389, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2071747 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2071747 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact: /cc @yanpzhan

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 01 '22 11:08 openshift-ci[bot]

/lgtm

rhamilto avatar Aug 01 '22 11:08 rhamilto

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 01 '22 11:08 openshift-ci[bot]

/retest

jhadvig avatar Aug 01 '22 12:08 jhadvig

/retest

jhadvig avatar Aug 02 '22 14:08 jhadvig

@jhadvig currently the variable "moreLinkURL" has been reset in https://github.com/openshift/console/pull/11768/files as below:

const moreLinkURL = getDocumentationURL( documentationURLs.postInstallationMachineConfigurationTasks, ); Does this pr need update accordingly? or just leave it and test as it is and wait for another backport from pr11768?

yanpzhan avatar Aug 03 '22 06:08 yanpzhan

@yanpzhan no, we wont be backporting https://github.com/openshift/console/pull/11768, since its introducing more changes then we need. Just this PR should go in.

jhadvig avatar Aug 08 '22 14:08 jhadvig

Thanks Jakub. Since the fix in the pr works as expected, the test passed. /label qe-approved

yanpzhan avatar Aug 09 '22 00:08 yanpzhan

/label cherry-pick-approved

yapei avatar Aug 09 '22 02:08 yapei

/retest

rhamilto avatar Aug 15 '22 13:08 rhamilto

/test e2e-gcp-console

jhadvig avatar Aug 22 '22 05:08 jhadvig

/retest

rhamilto avatar Aug 24 '22 13:08 rhamilto

/retest

rhamilto avatar Aug 24 '22 13:08 rhamilto

/retest

rhamilto avatar Aug 24 '22 14:08 rhamilto

/test e2e-gcp-console

jhadvig avatar Sep 09 '22 08:09 jhadvig

/test e2e-gcp-console

jhadvig avatar Sep 13 '22 09:09 jhadvig

/label backport-risk-assessed

jhadvig avatar Sep 13 '22 12:09 jhadvig

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 13 '22 14:09 openshift-ci[bot]

@jhadvig: Bugzilla bug 2080389 is in an unrecognized state (CLOSED (WONTFIX)) and will not be moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2080389: Link to documentation from the overview page goes to a missing link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 13 '22 14:09 openshift-ci[bot]