openshift
Fix zh locale (greater than pod)
Hi @raspbeep. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
This bug also exists in ja and ko. https://github.com/openshift/console/blob/master/frontend/public/components/modals/configure-update-strategy-modal.tsx#L76 is the source of the bug. For some reason, the keys aren't generating properly.
For some reason, the keys aren't generating properly.
@cyril-ui-developer, do you know how *_plural keys work in the non-en files?
For some reason, the keys aren't generating properly.
@cyril-ui-developer, do you know how
*_pluralkeys work in the non-en files?
@rhamilto No. But I have seen a couple of non-en files using _0 for plural.
For example in Max available : https://github.com/openshift/console/blob/master/frontend/packages/console-app/locales/zh/console-app.json#L350
@raspbeep: This pull request references Bugzilla bug 2102681, which is invalid:
- expected the bug to target the "4.12.0" release, but it targets "---" instead
Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
Bug 2102681: Fix zh locale (greater than pod)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jhadvig: This pull request references Bugzilla bug 2102681, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target release (4.12.0) matches configured target release for branch (4.12.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Requesting review from QA contact: /cc @yapei
In response to this:
/bugzilla refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, raspbeep
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [jhadvig]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 2 against base HEAD 3d99fb05013d8ba030519d4f0ada228f4b00bc62 and 8 for PR HEAD 79acb2ff65e033c36f36d17a1130d9937cd45962 in total
@raspbeep: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@raspbeep: All pull requests linked via external trackers have merged:
Bugzilla bug 2102681 has been moved to the MODIFIED state.
In response to this:
Bug 2102681: Fix zh locale (greater than pod)
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.