console icon indicating copy to clipboard operation
console copied to clipboard

Bug 2091102: Name of workload get changed, when project and image stream gets changed on edit deployment page of the workload

Open Lucifergene opened this issue 3 years ago • 15 comments

Fixes:

https://issues.redhat.com/browse/OCPBUGSM-44809

Analysis / Root cause:

Name of workload get changed, when project and image stream gets changed on edit deployment page of the workload.

Solution Description:

Workload name doesn't have to be changed, when image stream name changed on edit deployment page, as name field is not changeable.

Screen shots / Gifs for design review:

https://user-images.githubusercontent.com/47265560/175432164-ca6f6b35-26d7-4446-bc7c-92e5261d02c3.mp4

Unit test coverage report:

No Change

Test setup:

  1. Create a deployment workload
  2. Select Edit Deployment option on workload
  3. Verify initially name was same as workload name and field was not changeable.
  4. Change the project to "openshift", image stream to "golang" or anything and tag to "latest"
  5. Now check that the name also got changed to golang.

Browser conformance:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge

Lucifergene avatar Jun 23 '22 23:06 Lucifergene

@Lucifergene: This pull request references Bugzilla bug 2091102, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to this:

Bug 2091102: Name of workload get changed, when project and image stream gets changed on edit deployment page of the workload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jun 23 '22 23:06 openshift-ci[bot]

/retest

Lucifergene avatar Jun 24 '22 05:06 Lucifergene

@Lucifergene there is an issue with frontend job as well, PTAL

invincibleJai avatar Jul 05 '22 07:07 invincibleJai

@Lucifergene there is an issue with the frontend job as well, PTAL

Sure @invincibleJai. I am also trying to find an alternate fix to this as mentioned by @jerolimov

Lucifergene avatar Jul 05 '22 07:07 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Jul 07 '22 17:07 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Jul 08 '22 17:07 Lucifergene

/retest

christoph-jerolimov avatar Jul 14 '22 15:07 christoph-jerolimov

/test e2e-gcp-console

Lucifergene avatar Jul 20 '22 11:07 Lucifergene

/retest-required

Lucifergene avatar Jul 20 '22 12:07 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Jul 20 '22 14:07 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Jul 25 '22 08:07 Lucifergene

/test e2e-gcp-console

Lucifergene avatar Jul 27 '22 22:07 Lucifergene

/assign @divyanshiGupta

Lucifergene avatar Aug 01 '22 16:08 Lucifergene

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 22 '22 23:08 openshift-ci[bot]

/lgtm

divyanshiGupta avatar Aug 23 '22 10:08 divyanshiGupta

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 23 '22 11:08 openshift-ci[bot]

@Lucifergene: All pull requests linked via external trackers have merged:

Bugzilla bug 2091102 has been moved to the MODIFIED state.

In response to this:

Bug 2091102: Name of workload get changed, when project and image stream gets changed on edit deployment page of the workload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 23 '22 15:08 openshift-ci[bot]