cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

LOG-7889: Fields not getting pruned for loki output

Open Clee2691 opened this issue 3 months ago • 6 comments

Description

This PR decouples Lokistack labels from Loki.

For Lokistack:

  • App and infra logs will include log type, host, and container labels along with their Otel equivalents.
  • Audit logs will NOT include container labels but will include log type and host labels along with their Otel equivalents.

For Loki:

  • log type, host, and container labels will be added by default without their Otel equivalents if no LabelKeys are defined.

/cc @cahartma @vparfonov /assign @jcantrill

Links

  • JIRA: https://issues.redhat.com/browse/LOG-7889

Clee2691 avatar Oct 28 '25 02:10 Clee2691

@Clee2691: This pull request references LOG-7889 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR decouples Lokistack labels from Loki.

For Lokistack:

  • App and infra logs will include log type, host, and container labels along with their Otel equivalents.
  • Audit logs will NOT include container labels but will include log type and host labels along with their Otel equivalents.

For Loki:

  • log type, host, and container labels will be added by default without their Otel equivalents if no LabelKeys are defined.

/cc @cahartma @vparfonov /assign @jcantrill

Links

  • JIRA: https://issues.redhat.com/browse/LOG-7889

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 28 '25 02:10 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Oct 28 '25 02:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Clee2691 Once this PR has been reviewed and has the lgtm label, please assign alanconway for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 28 '25 02:10 openshift-ci[bot]

/test all

Clee2691 avatar Oct 28 '25 02:10 Clee2691

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 28 '25 04:10 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Nov 05 '25 15:11 openshift-merge-robot