cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

[release-5.9] LOG-5156: Add rotated files to exclude_paths globs

Open cahartma opened this issue 1 year ago • 3 comments

Description

Simple change, but need to make sure it's complete and my logic is sound. I rewrote this one final time and simply added the exclude pattern for rotated logs.

Vector config exclude glob patterns all end with *.log. This results in rotated infra log files being sent to the app index in certain scenarios. This change adds .log.* to the existing excluded extensions to avoid any rotated files being collected. the .gz and .tmp extensions are already added to exclude in all cases.

/cc @Clee2691 @vparfonov /assign @jcantrill

/cherry-pick master

Links

  • JIRA: https://issues.redhat.com/browse/LOG-5156

cahartma avatar Apr 30 '24 19:04 cahartma

@cahartma: This pull request references LOG-5156 which is a valid jira issue.

In response to this:

Description

Simple change, but need to make sure it's complete and my logic is sound. I rewrote this one final time and simply added the exclude pattern for rotated logs.

Vector config exclude glob patterns all end with *.log. This results in rotated infra log files being sent to the app index in certain scenarios. This change adds .log.* to the existing excluded extensions to avoid any rotated files being collected. the .gz and .tmp extensions are already added to exclude in all cases.

/cc @Clee2691 @vparfonov /assign @jcantrill

/cherry-pick master

Links

  • JIRA: https://issues.redhat.com/browse/LOG-5156

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 30 '24 19:04 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 30 '24 19:04 openshift-ci[bot]

/retest

cahartma avatar May 06 '24 16:05 cahartma

/lgtm

Clee2691 avatar May 06 '24 19:05 Clee2691

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 06 '24 22:05 openshift-ci[bot]