cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard
verified publisher icon openshift

LOG-3210: Refactor cluster rbac into reconcile package

Open jcantrill opened this issue 3 years ago • 5 comments

Description

This PR:

  • Refactors cluster RBAC reconciliation into reconcile package
  • Modifies logstore rbac generation to use runtime package
  • Moves cluster rbac comparitors into common package
  • Adds event recording to cluster rbac reconciliation

Links

  • https://issues.redhat.com/browse/LOG-3210

jcantrill avatar Oct 20 '22 20:10 jcantrill

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 20 '22 20:10 openshift-ci[bot]

/retest

jcantrill avatar Oct 21 '22 01:10 jcantrill

/retest

jcantrill avatar Oct 24 '22 15:10 jcantrill

/retest

jcantrill avatar Oct 25 '22 18:10 jcantrill

/lgtm

vparfonov avatar Oct 26 '22 15:10 vparfonov

@jcantrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-next df39413172166b4ec8132107bd610c3c0593c2e6 link false /test e2e-ocp-next

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 26 '22 16:10 openshift-ci[bot]