cluster-logging-operator icon indicating copy to clipboard operation
cluster-logging-operator copied to clipboard

LOG-3145: dedot vector tag value

Open cahartma opened this issue 3 years ago • 5 comments

Description

A customer who has switched collectors found that in vector the value of the "tag" field has a dot pre-pended. In fluentd this field value was without the dot.
This is the first I've heard of a customer actually using this field, as it is not intended to be part of our data model. It's used to create stream names (based on the type of file) when using cloudwatch, then the tag field is deleted. In this case, the customer is not using CW output, and thus the tag field remains. As with a few other fields, this only remains for feature parity with fluentd.

/cc @vimalk78 @syedriko /assign @jcantrill

Links

  • https://issues.redhat.com/browse/LOG-3145

cahartma avatar Oct 18 '22 20:10 cahartma

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cahartma Once this PR has been reviewed and has the lgtm label, please ask for approval from jcantrill by writing /assign @jcantrill in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 18 '22 21:10 openshift-ci[bot]

/retest

cahartma avatar Oct 19 '22 13:10 cahartma

/retest

cahartma avatar Oct 20 '22 12:10 cahartma

/hold

cahartma avatar Oct 20 '22 13:10 cahartma

@cahartma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-next 43798b6b2229d15761b8d45594d19a39a7e5c81a link false /test e2e-ocp-next

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 20 '22 14:10 openshift-ci[bot]

Closed as will not be fixing the tag field.  It was never part of our model and is therefor a bug that it exists.

cahartma avatar Oct 26 '22 19:10 cahartma