openshift
all info metrics of Gauge type now got two values : 0 and 1, on chang…
Description
[LOG-2315] All info metrics in CLO are implemented as Gauge type where values of those metrics were fixed to have a constant value '1'. This was causing issue as when the labels attain a different value. For each unique value of labels - prometheus creates a new time-series with update label-value pair. It still keeps the older label-value pair alive with the older state of metric time-series. To address this now all info type of clo metrics accommodate two values - 0 and 1. When metric labels attain a different value then the previous state of metric with old label-value pair is reset to 0.
/cc @alanconway /assign @jcantrill
Links
- Depending on PR(s):
- Bugzilla:
- Github issue:
- JIRA: https://issues.redhat.com/browse/LOG-2315
- Enhancement proposal:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcantrill, pmoogi-redhat
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jcantrill]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.5 in a new PR and assign it to you.
In response to this:
/cherrypick release-5.5
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@pmoogi-redhat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@jcantrill: #1623 failed to apply on top of branch "release-5.5":
Applying: all info metrics of Gauge type now got two values : 0 and 1, on changed values of label (keys) the previous instance of metric is reset to 0 now
Using index info to reconstruct a base tree...
M controllers/forwarding/forwarding_controller.go
M internal/k8shandler/reconciler.go
Falling back to patching base and 3-way merge...
Auto-merging internal/k8shandler/reconciler.go
Auto-merging controllers/forwarding/forwarding_controller.go
CONFLICT (content): Merge conflict in controllers/forwarding/forwarding_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 all info metrics of Gauge type now got two values : 0 and 1, on changed values of label (keys) the previous instance of metric is reset to 0 now
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherrypick release-5.5
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.