openshift
LOG-2285: Fix disabling certificate validation for Kafka output
Description
During #1548 I failed to realize that the Kafka output for vector does not use the common tls.* options for disabling validation of the certificate.
This PR fixes two issues with the Kafka output:
- TLS was not enabled if the URL contained a
tls://scheme but the secret did not contain any other TLS options - Use Kafka's custom option to disable verification of the certificate
/cc @cahartma /assign @alanconway
Links
- JIRA: LOG-2285
/retest-required
Remaining retests: 2 against base HEAD 3f272124c5faacec7ec8887842b260804b04265a and 8 for PR HEAD c5fe39efc6b0b519c40ac0ed3471ef9584c63fff in total
/retest-required
Remaining retests: 1 against base HEAD 3f272124c5faacec7ec8887842b260804b04265a and 7 for PR HEAD c5fe39efc6b0b519c40ac0ed3471ef9584c63fff in total
/retest-required
Remaining retests: 0 against base HEAD 3f272124c5faacec7ec8887842b260804b04265a and 6 for PR HEAD c5fe39efc6b0b519c40ac0ed3471ef9584c63fff in total
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alanconway, jcantrill, xperimental
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [alanconway,jcantrill]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm trying my luck with a rebase to the current master. Needs another lgtm though ...
/retest-required
Remaining retests: 2 against base HEAD 7b576316155449d364796e2b850c0fb9bcd1bd3f and 8 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 1 against base HEAD 7b576316155449d364796e2b850c0fb9bcd1bd3f and 7 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 0 against base HEAD 7b576316155449d364796e2b850c0fb9bcd1bd3f and 6 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 2 against base HEAD 7f58d37d11bfe887ab240afeadb2d1741e97445d and 5 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 1 against base HEAD 7f58d37d11bfe887ab240afeadb2d1741e97445d and 4 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 0 against base HEAD 7f58d37d11bfe887ab240afeadb2d1741e97445d and 3 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 2 against base HEAD 517309f792215cd77ab6f071a42277065352012b and 2 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 1 against base HEAD 517309f792215cd77ab6f071a42277065352012b and 1 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/retest-required
Remaining retests: 0 against base HEAD 517309f792215cd77ab6f071a42277065352012b and 0 for PR HEAD 041e469dccf0f581f6d75592c65c7484b0b6bdb2 in total
/hold
Revision 041e469dccf0f581f6d75592c65c7484b0b6bdb2 was retested 9 times: holding
/retest-required
Remaining retests: 2 against base HEAD 5de4a1700a852e6774d12b53eed0c26df16faf06 and 8 for PR HEAD cdd563968ae2f145ca344c07d4c484d24553c9c1 in total