cincinnati icon indicating copy to clipboard operation
cincinnati copied to clipboard

OTA-15: Return `400 Bad Request` for responses that contain an empty graph

Open DavidHurta opened this issue 1 year ago • 16 comments

Return 400 Bad Request for responses that contain an empty graph. Such responses are currently only generated when a specified channel and architecture result in an empty update graph due to the filtering.

This commit is part of the effort to improve the UX regarding requests that contain invalid query parameters. In the future, more fine-grained return messages will be returned.

This pull request references https://issues.redhat.com/browse/OTA-15

DavidHurta avatar Aug 29 '24 15:08 DavidHurta

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Aug 29 '24 15:08 openshift-ci[bot]

/test all

DavidHurta avatar Aug 29 '24 15:08 DavidHurta

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Davoska Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 29 '24 15:08 openshift-ci[bot]

/test all

DavidHurta avatar Aug 30 '24 09:08 DavidHurta

/test all

DavidHurta avatar Aug 30 '24 12:08 DavidHurta

/test ci/prow/cargo-test

DavidHurta avatar Aug 30 '24 12:08 DavidHurta

@Davoska: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test cargo-test
  • /test customrust-cargo-test
  • /test customrust-e2e
  • /test customrust-images
  • /test customrust-rustfmt-1.64.0
  • /test customrust-rustfmt-1.70.0
  • /test customrust-yaml-lint
  • /test e2e
  • /test images
  • /test rustfmt-1.64.0
  • /test rustfmt-1.70.0
  • /test yaml-lint

Use /test all to run all jobs.

In response to this:

/test ci/prow/cargo-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 30 '24 12:08 openshift-ci[bot]

/test cargo-test

DavidHurta avatar Aug 30 '24 12:08 DavidHurta

/test cargo-test

DavidHurta avatar Aug 30 '24 13:08 DavidHurta

/test cargo-test

DavidHurta avatar Aug 30 '24 13:08 DavidHurta

/test cargo-test

DavidHurta avatar Aug 30 '24 18:08 DavidHurta

@Davoska: This pull request references OTA-15 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 02 '24 11:09 openshift-ci-robot

@Davoska: This pull request references OTA-15 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Return 400 Bad Request for responses that contain an empty graph. Such responses are currently only generated when a specified channel and architecture result in an empty update graph due to the filtering.

This commit is part of the effort to improve the UX regarding requests that contain invalid query parameters. In the future, more fine-grained return messages will be returned.

This pull request references https://issues.redhat.com/browse/OTA-15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 02 '24 11:09 openshift-ci-robot

/test all

DavidHurta avatar Sep 02 '24 11:09 DavidHurta

/test all

DavidHurta avatar Sep 06 '24 12:09 DavidHurta

@Davoska: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/customrust-cargo-test 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df link true /test customrust-cargo-test
ci/prow/e2e 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df link true /test e2e
ci/prow/cargo-test 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df link true /test cargo-test
ci/prow/customrust-e2e 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df link true /test customrust-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 06 '24 13:09 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Dec 06 '24 01:12 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jan 05 '25 08:01 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Feb 05 '25 00:02 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Feb 05 '25 00:02 openshift-ci[bot]