OTA-15: Return `400 Bad Request` for responses that contain an empty graph
Return 400 Bad Request for responses that contain an empty graph. Such
responses are currently only generated when a specified channel and
architecture result in an empty update graph due to the filtering.
This commit is part of the effort to improve the UX regarding requests that contain invalid query parameters. In the future, more fine-grained return messages will be returned.
This pull request references https://issues.redhat.com/browse/OTA-15
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Davoska Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test all
/test all
/test ci/prow/cargo-test
@Davoska: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
-
/test cargo-test -
/test customrust-cargo-test -
/test customrust-e2e -
/test customrust-images -
/test customrust-rustfmt-1.64.0 -
/test customrust-rustfmt-1.70.0 -
/test customrust-yaml-lint -
/test e2e -
/test images -
/test rustfmt-1.64.0 -
/test rustfmt-1.70.0 -
/test yaml-lint
Use /test all to run all jobs.
In response to this:
/test ci/prow/cargo-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test cargo-test
/test cargo-test
/test cargo-test
/test cargo-test
@Davoska: This pull request references OTA-15 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Davoska: This pull request references OTA-15 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Return
400 Bad Requestfor responses that contain an empty graph. Such responses are currently only generated when a specified channel and architecture result in an empty update graph due to the filtering.This commit is part of the effort to improve the UX regarding requests that contain invalid query parameters. In the future, more fine-grained return messages will be returned.
This pull request references https://issues.redhat.com/browse/OTA-15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/test all
/test all
@Davoska: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/customrust-cargo-test | 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df | link | true | /test customrust-cargo-test |
| ci/prow/e2e | 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df | link | true | /test e2e |
| ci/prow/cargo-test | 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df | link | true | /test cargo-test |
| ci/prow/customrust-e2e | 0d7d4bad3fbe3af3e5c78e2ec85de7297d9725df | link | true | /test customrust-e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.