cincinnati-graph-data icon indicating copy to clipboard operation
cincinnati-graph-data copied to clipboard

build_suggestions: bump 4.21 minimum upgrade version to 4.20.12

Open haircommander opened this issue 1 month ago • 4 comments

so upgrades go through https://github.com/openshift/machine-config-operator/pull/5516

haircommander avatar Jan 16 '26 14:01 haircommander

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Jan 16 '26 14:01 coderabbitai[bot]

context: in cri-o 1.33, a change https://github.com/cri-o/cri-o/pull/8962 was made to the default limits set for CRI-O. Now, the ulimit nofile is set much lower, with space to set it higher. however, some workloads don't expect this change, and fail (see https://issues.redhat.com/browse/OCPBUGS-62095)

This was worked around temporarily in https://github.com/openshift/machine-config-operator/pull/5308, but that workaround was not intendd to be carried in to 4.21.

Instead, we should drop-in an ignition file on upgrades from 4.20 to 4.21 to make sure existing clusters don't get this change, but new clusters started in 4.21 do.

Now we need to make sure upgrades go through that PR. it missed 4.20.11 by a day, so I feel confident it will land in 4.20.12

haircommander avatar Jan 16 '26 14:01 haircommander

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander Once this PR has been reviewed and has the lgtm label, please assign hongkailiu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 16 '26 14:01 openshift-ci[bot]

@haircommander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 16 '26 15:01 openshift-ci[bot]